Skip to content

Closes #7663 (add routing for pre-indexed shapes) #7667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

helllamer
Copy link

As discussed early in #7663, there no way to provide routing information for pre-indexed shape in GeoShape filters and queries. This PR contains fixes for this issue:
Adds optional routing parameter to indexed_shape object in GeoShape builder/parser for filter and query.
Adds test for mandatory-routed pre-indexed GeoShape search.
Adds routing parameter description into geo_shape filter asciidoc.

@clintongormley
Copy link
Contributor

thanks for the PR @helllamer - we'll take a look at it.

@colings86
Copy link
Contributor

@helllamer thanks for the PR. It looks good to me so I will get another review and try to get it merged in for you.

@clintongormley
Copy link
Contributor

@martijnvg could you review this one please

@martijnvg
Copy link
Member

@helllamer Your change looks good, would you like to turn the PR into a single commit and rebase with master? If you don't have time for this now then I will do it in a couple of days. Sorry that it took so long to respond!

@helllamer
Copy link
Author

Hi, Martijn. I,m on newyear holidays, far away from keyboard. Cannot help you this week...

Martijn van Groningen [email protected] пишет:

@helllamer Your change looks good, would you like to turn the PR into a
single commit and rebase with master? If you don't have time for this
now then I will do it in a couple of days. Sorry that it took so long
to respond!


Reply to this email directly or view it on GitHub:
#7667 (comment)

@martijnvg
Copy link
Member

@helllamer No problem at all. If happen to have some time this week then that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants