[DOCS] Update anchor and add redirect for aliases #77349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PRs #73062 and #73043 repurposed the `alias` anchor for a new guide for index and data stream aliases. Previously, this anchor was used for our field alias documentation. Repurposing the anchor has caused continuity errors for users selecting different versions of the ES docs. It could also cause confusion for users with a `/current/` link to the `alias` page. This updates the anchor for the alias guide and adds a redirect page to disambiguate the `alias` anchor. It also fixes a bread crumb issue for redirects following the 'Modifying your Data' redirect page. Closes #77034.
jrodewig
commented
Sep 7, 2021
| [role="exclude",id="alias"] | ||
| === Aliases | ||
|
|
||
| For field aliases, refer to <<field-alias>>. |
There was a problem hiding this comment.
In 7.13 and 7.12, I'll only include this portion of the redirect.
|
Pinging @elastic/es-docs (Team:Docs) |
lockewritesdocs
approved these changes
Sep 7, 2021
There was a problem hiding this comment.
Tested the output, and it's looking great. 👍 thanks for tackling this one @jrodewig!
|
Thanks @lockewritesdocs! |
This was referenced Sep 7, 2021
jrodewig
added a commit
that referenced
this pull request
Sep 7, 2021
PRs #73062 and #73043 repurposed the `alias` anchor for a new guide for index and data stream aliases. Previously, this anchor was used for our field alias documentation. Repurposing the anchor has caused continuity errors for users selecting different versions of the ES docs. It could also cause confusion for users with a `/current/` link to the `alias` page. This adds a redirect page for the `alias` anchor. It also fixes a bread crumb issue for redirects following the 'Modifying your Data' redirect page.
jrodewig
added a commit
that referenced
this pull request
Sep 7, 2021
PRs #73062 and #73043 repurposed the `alias` anchor for a new guide for index and data stream aliases. Previously, this anchor was used for our field alias documentation. Repurposing the anchor has caused continuity errors for users selecting different versions of the ES docs. It could also cause confusion for users with a `/current/` link to the `alias` page. This adds a redirect page for the `alias` anchor. It also fixes a bread crumb issue for redirects following the 'Modifying your Data' redirect page.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 7, 2021
…7357) * [DOCS] Update anchor and add redirect for aliases (#77349) PRs #73062 and #73043 repurposed the `alias` anchor for a new guide for index and data stream aliases. Previously, this anchor was used for our field alias documentation. Repurposing the anchor has caused continuity errors for users selecting different versions of the ES docs. It could also cause confusion for users with a `/current/` link to the `alias` page. This updates the anchor for the alias guide and adds a redirect page to disambiguate the `alias` anchor. It also fixes a bread crumb issue for redirects following the 'Modifying your Data' redirect page. Closes #77034. # Conflicts: # docs/reference/search/multi-search.asciidoc * [DOCS] Add anchor text to field alias redirect
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 7, 2021
…7356) * [DOCS] Update anchor and add redirect for aliases (#77349) PRs #73062 and #73043 repurposed the `alias` anchor for a new guide for index and data stream aliases. Previously, this anchor was used for our field alias documentation. Repurposing the anchor has caused continuity errors for users selecting different versions of the ES docs. It could also cause confusion for users with a `/current/` link to the `alias` page. This updates the anchor for the alias guide and adds a redirect page to disambiguate the `alias` anchor. It also fixes a bread crumb issue for redirects following the 'Modifying your Data' redirect page. Closes #77034. # Conflicts: # docs/reference/search/multi-search.asciidoc * [DOCS] Add anchor text to field alias redirect
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 7, 2021
) * [DOCS] Update anchor and add redirect for aliases (#77349) PRs #73062 and #73043 repurposed the `alias` anchor for a new guide for index and data stream aliases. Previously, this anchor was used for our field alias documentation. Repurposing the anchor has caused continuity errors for users selecting different versions of the ES docs. It could also cause confusion for users with a `/current/` link to the `alias` page. This updates the anchor for the alias guide and adds a redirect page to disambiguate the `alias` anchor. It also fixes a bread crumb issue for redirects following the 'Modifying your Data' redirect page. Closes #77034. # Conflicts: # docs/reference/search/multi-search.asciidoc * [DOCS] Add anchor text to field alias redirect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs #73062 and #73043 repurposed the
aliasanchor for a new guide for indexand data stream aliases. Previously, this anchor was used for our field alias
documentation.
Repurposing the anchor has caused continuity errors for users selecting
different versions of the ES docs. It could also cause confusion for users with
a
/current/link to thealiaspage.This updates the anchor for the alias guide and adds a redirect page to
disambiguate the
aliasanchor.It also fixes a bread crumb issue for redirects following the 'Modifying your
Data' redirect page.
Closes #77034.