Remove unnecessary SPI reload calls #77680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
added
:Search Relevance/Analysis
elasticmachine
added
Team:Search
|
Pinging @elastic/es-search (Team:Search) |
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
💔 Backport failed
You can use sqren/backport to manually backport by running |
romseygeek
added a commit
that referenced
this pull request
Sep 14, 2021
The PluginsService calls various lucene SPI reload methods to ensure that lookups done via eg Codec.forName() will find classes that have been added via a plugin. We also call SPI reloads for analysis components (CharFilters, Tokenizers and TokenFilters). However, this is unnecessary, because elasticsearch uses its own factory abstractions for these components and never uses lucene SPI to load them. This commit removes the unnecessary SPI calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PluginsService calls various lucene SPI reload methods to ensure that lookups
done via eg
Codec.forName()will find classes that have been added via a plugin.We also call SPI reloads for analysis components (CharFilters, Tokenizers and
TokenFilters). However, this is unnecessary, because elasticsearch uses its own
factory abstractions for these components and never uses lucene SPI to load them.
This commit removes the unnecessary SPI calls.