Skip to content

Optimize XContent Object Parsers #78813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 21, 2021
Merged

Optimize XContent Object Parsers #78813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cc04abb
Optimize XContent Object Parsers
original-brownbear Oct 7, 2021
e85f3b5
Merge remote-tracking branch 'elastic/master' into optimize-object-pa…
original-brownbear Oct 7, 2021
943674d
fix test
original-brownbear Oct 7, 2021
4321688
Merge remote-tracking branch 'elastic/master' into optimize-object-pa…
original-brownbear Oct 7, 2021
2eddec2
Merge remote-tracking branch 'elastic/master' into optimize-object-pa…
original-brownbear Oct 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libs/x-content/src/main/java/org/elasticsearch/xcontent/AbstractObjectParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ public <T> void declareField(BiConsumer<Value, T> consumer, CheckedFunction<XCon
}

public <T> void declareObject(BiConsumer<Value, T> consumer, ContextParser<Context, T> objectParser, ParseField field) {
declareField(consumer, (p, c) -> objectParser.parse(p, c), field, ValueType.OBJECT);
declareField(consumer, objectParser, field, ValueType.OBJECT);
}

/**
Expand Down Expand Up @@ -240,7 +240,7 @@ public void declareBoolean(BiConsumer<Value, Boolean> consumer, ParseField field
}

public <T> void declareObjectArray(BiConsumer<Value, List<T>> consumer, ContextParser<Context, T> objectParser, ParseField field) {
declareFieldArray(consumer, (p, c) -> objectParser.parse(p, c), field, ValueType.OBJECT_ARRAY);
declareFieldArray(consumer, objectParser, field, ValueType.OBJECT_ARRAY);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion libs/x-content/src/main/java/org/elasticsearch/xcontent/ConstructingObjectParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ private class Target {
/**
* The parse context that is used for this invocation. Stored here so that it can be passed to the {@link #builder}.
*/
private Context context;
private final Context context;

/**
* How many of the constructor parameters have we collected? We keep track of this so we don't have to count the
Expand Down
Loading