Skip to content

[DOCS] Fix default value for closed indices #78924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 13, 2021

Conversation

lockewritesdocs
Copy link
Contributor

#57953 introduced changes that added ESS icons to many Elasticsearch settings. As part of those changes, the default value for cluster.indices.close.enable was indicated as false, when it should be true. This PR updates the default value to true.

Closes #78877

#57953 introduced changes that added ESS icons to many Elasticsearch settings. As part of those changes, the default value for `cluster.indices.close.enable` was indicated as `false`, when it should be `true`. This PR updates the default value to `true`. 

Closes #78877
@lockewritesdocs lockewritesdocs added >docs General docs changes :Data Management/Indices APIs APIs to create and manage indices and templates v7.8.1 v7.9.3 v7.10.2 v7.11.2 v7.12.1 v7.13.3 auto-backport Automatically create backport pull requests when merged v7.16.0 v7.15.1 v7.14.2 labels Oct 11, 2021
@lockewritesdocs lockewritesdocs self-assigned this Oct 11, 2021
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Data Management Meta label for data/management team labels Oct 11, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this @lockewritesdocs. I think an engineer should take a look before we merge. In particular, I think the IMPORTANT admon may be outdated.

Copy link
Contributor

@gwbrown gwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@lockewritesdocs lockewritesdocs added auto-backport-and-merge and removed auto-backport Automatically create backport pull requests when merged labels Oct 13, 2021
@lockewritesdocs lockewritesdocs merged commit c3b67ee into master Oct 13, 2021
@lockewritesdocs lockewritesdocs deleted the docs__fix-indices.close-default branch October 13, 2021 12:14
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Oct 13, 2021
* [DOCS] Fix default value for closed indices

elastic#57953 introduced changes that added ESS icons to many Elasticsearch settings. As part of those changes, the default value for `cluster.indices.close.enable` was indicated as `false`, when it should be `true`. This PR updates the default value to `true`. 

Closes elastic#78877

* Update description

* Update note to remove outdated claims
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Oct 13, 2021
* [DOCS] Fix default value for closed indices

elastic#57953 introduced changes that added ESS icons to many Elasticsearch settings. As part of those changes, the default value for `cluster.indices.close.enable` was indicated as `false`, when it should be `true`. This PR updates the default value to `true`. 

Closes elastic#78877

* Update description

* Update note to remove outdated claims
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Oct 13, 2021
* [DOCS] Fix default value for closed indices

elastic#57953 introduced changes that added ESS icons to many Elasticsearch settings. As part of those changes, the default value for `cluster.indices.close.enable` was indicated as `false`, when it should be `true`. This PR updates the default value to `true`. 

Closes elastic#78877

* Update description

* Update note to remove outdated claims
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Oct 13, 2021
* [DOCS] Fix default value for closed indices

elastic#57953 introduced changes that added ESS icons to many Elasticsearch settings. As part of those changes, the default value for `cluster.indices.close.enable` was indicated as `false`, when it should be `true`. This PR updates the default value to `true`. 

Closes elastic#78877

* Update description

* Update note to remove outdated claims
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Oct 13, 2021
* [DOCS] Fix default value for closed indices

elastic#57953 introduced changes that added ESS icons to many Elasticsearch settings. As part of those changes, the default value for `cluster.indices.close.enable` was indicated as `false`, when it should be `true`. This PR updates the default value to `true`. 

Closes elastic#78877

* Update description

* Update note to remove outdated claims
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Oct 13, 2021
* [DOCS] Fix default value for closed indices

elastic#57953 introduced changes that added ESS icons to many Elasticsearch settings. As part of those changes, the default value for `cluster.indices.close.enable` was indicated as `false`, when it should be `true`. This PR updates the default value to `true`. 

Closes elastic#78877

* Update description

* Update note to remove outdated claims
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Oct 13, 2021
* [DOCS] Fix default value for closed indices

elastic#57953 introduced changes that added ESS icons to many Elasticsearch settings. As part of those changes, the default value for `cluster.indices.close.enable` was indicated as `false`, when it should be `true`. This PR updates the default value to `true`. 

Closes elastic#78877

* Update description

* Update note to remove outdated claims
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
7.8 Commit could not be cherrypicked due to conflicts
7.9
7.10
7.11
7.12
7.13
7.x
7.15
7.14

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 78924

lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Oct 13, 2021
* [DOCS] Fix default value for closed indices

elastic#57953 introduced changes that added ESS icons to many Elasticsearch settings. As part of those changes, the default value for `cluster.indices.close.enable` was indicated as `false`, when it should be `true`. This PR updates the default value to `true`. 

Closes elastic#78877

* Update description

* Update note to remove outdated claims
elasticsearchmachine pushed a commit that referenced this pull request Oct 13, 2021
* [DOCS] Fix default value for closed indices

#57953 introduced changes that added ESS icons to many Elasticsearch settings. As part of those changes, the default value for `cluster.indices.close.enable` was indicated as `false`, when it should be `true`. This PR updates the default value to `true`. 

Closes #78877

* Update description

* Update note to remove outdated claims
elasticsearchmachine pushed a commit that referenced this pull request Oct 13, 2021
* [DOCS] Fix default value for closed indices

#57953 introduced changes that added ESS icons to many Elasticsearch settings. As part of those changes, the default value for `cluster.indices.close.enable` was indicated as `false`, when it should be `true`. This PR updates the default value to `true`. 

Closes #78877

* Update description

* Update note to remove outdated claims
elasticsearchmachine pushed a commit that referenced this pull request Oct 13, 2021
* [DOCS] Fix default value for closed indices

#57953 introduced changes that added ESS icons to many Elasticsearch settings. As part of those changes, the default value for `cluster.indices.close.enable` was indicated as `false`, when it should be `true`. This PR updates the default value to `true`. 

Closes #78877

* Update description

* Update note to remove outdated claims
elasticsearchmachine pushed a commit that referenced this pull request Oct 13, 2021
* [DOCS] Fix default value for closed indices

#57953 introduced changes that added ESS icons to many Elasticsearch settings. As part of those changes, the default value for `cluster.indices.close.enable` was indicated as `false`, when it should be `true`. This PR updates the default value to `true`. 

Closes #78877

* Update description

* Update note to remove outdated claims
elasticsearchmachine pushed a commit that referenced this pull request Oct 13, 2021
* [DOCS] Fix default value for closed indices

#57953 introduced changes that added ESS icons to many Elasticsearch settings. As part of those changes, the default value for `cluster.indices.close.enable` was indicated as `false`, when it should be `true`. This PR updates the default value to `true`. 

Closes #78877

* Update description

* Update note to remove outdated claims
elasticsearchmachine pushed a commit that referenced this pull request Oct 13, 2021
* [DOCS] Fix default value for closed indices

#57953 introduced changes that added ESS icons to many Elasticsearch settings. As part of those changes, the default value for `cluster.indices.close.enable` was indicated as `false`, when it should be `true`. This PR updates the default value to `true`. 

Closes #78877

* Update description

* Update note to remove outdated claims
elasticsearchmachine pushed a commit that referenced this pull request Oct 13, 2021
* [DOCS] Fix default value for closed indices

#57953 introduced changes that added ESS icons to many Elasticsearch settings. As part of those changes, the default value for `cluster.indices.close.enable` was indicated as `false`, when it should be `true`. This PR updates the default value to `true`. 

Closes #78877

* Update description

* Update note to remove outdated claims
elasticsearchmachine pushed a commit that referenced this pull request Oct 13, 2021
* [DOCS] Fix default value for closed indices

#57953 introduced changes that added ESS icons to many Elasticsearch settings. As part of those changes, the default value for `cluster.indices.close.enable` was indicated as `false`, when it should be `true`. This PR updates the default value to `true`. 

Closes #78877

* Update description

* Update note to remove outdated claims
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Oct 13, 2021
* [DOCS] Fix default value for closed indices

Closes elastic#78877

* Update description

* Update note to remove outdated claims
lockewritesdocs pushed a commit that referenced this pull request Oct 13, 2021
* [DOCS] Fix default value for closed indices

Closes #78877

* Update description

* Update note to remove outdated claims
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >docs General docs changes Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v7.8.1 v7.9.3 v7.10.2 v7.11.2 v7.12.1 v7.13.3 v7.14.2 v7.15.1 v7.16.0 v8.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] cluster.indices.close.enable default is incorrect
6 participants