Skip to content

Fix eclipse compilation for categorization agg #79252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Oct 15, 2021

Works around an eclipse bug where nested classes can't see things
imported by their parameterized outer classes. Tracked here:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=565255

@nik9000 nik9000 requested a review from benwtrent October 15, 2021 13:44
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Oct 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

Works around an eclipse bug where nested classes can't see things
imported by their parameterized outer classes. Tracked here:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=565255
@nik9000 nik9000 added auto-backport-and-merge auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Oct 15, 2021
@nik9000
Copy link
Member Author

nik9000 commented Oct 15, 2021

Thanks for helping me make the red squiggles go away, @benwtrent !

@elasticsearchmachine elasticsearchmachine merged commit fd78ac3 into elastic:master Oct 15, 2021
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

@nik9000
Copy link
Member Author

nik9000 commented Oct 15, 2021

green_heart Backport successful

Robot, I think you may be sick.

@nik9000
Copy link
Member Author

nik9000 commented Oct 15, 2021

Robot, I think you may be sick.

Oh! In fact! The backport is a noop! Ok then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :ml Machine learning >non-issue Team:ML Meta label for the ML team v8.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants