Skip to content

[DOCS] Document deprecation of storing nanosecond resolution on date field #79370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pgomulka
Copy link
Contributor

relates #78921

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@pgomulka pgomulka added >docs General docs changes v8.0.0 v7.16.1 labels Oct 18, 2021
@pgomulka pgomulka requested a review from jrodewig October 18, 2021 15:58
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Oct 18, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@pgomulka
Copy link
Contributor Author

@jrodewig this is meant to be a deprecation in both 7.16 and 8.0. Is there a separate section for deprecations only?
I placed this in a breaking changes for now.

@jrodewig jrodewig changed the title [doc] Document deprecation of storing nanosecond resolution on date field [DOCS] Document deprecation of storing nanosecond resolution on date field Oct 19, 2021
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pgomulka. I left some suggestions with edits.

@jrodewig this is meant to be a deprecation in both 7.16 and 8.0. Is there a separate section for deprecations only?

If we start deprecation in 7.16, we only need to add deprecation docs to the 7.16 migration guide: https://github.com/elastic/elasticsearch/edit/7.x/docs/reference/migration/migrate_7_16.asciidoc

We don't need to add these changes to the 8.0 migration guide at all. Instead, move these changes to the above file and rebase this PR against 7.x.

@pgomulka
Copy link
Contributor Author

in that case I will close this PR in favour of the 7.x PR
#79554

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes Team:Docs Meta label for docs team v7.16.0 v8.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants