[ML] Modernize ML node detection #79623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where possible we should now detect ML nodes by looking for the ML node role rather than an attribute. Sadly this is not possible in the YAML tests, as the syntax doesn't support asserting that a list contains a particular item without asserting on the entire list contents. So in the YAML case we need to look for the ml.machine_memory node attribute, as this is reliably set on ML nodes but not other types of nodes. After elastic#79622 is merged this closes elastic#79518
droberts195
added
>test
|
Pinging @elastic/ml-core (Team:ML) |
benwtrent
reviewed
Oct 21, 2021
| } catch (NumberFormatException e) { | ||
| return false; | ||
| } | ||
| return node.getRoles().contains(DiscoveryNodeRole.ML_ROLE); |
benwtrent
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where possible we should now detect ML nodes by looking
for the ML node role rather than an attribute.
Sadly this is not possible in the YAML tests, as the
syntax doesn't support asserting that a list contains
a particular item without asserting on the entire list
contents. So in the YAML case we need to look for the
ml.machine_memory node attribute, as this is reliably
set on ML nodes but not other types of nodes.
After #79622 is merged this closes #79518