Skip to content

Document removal of freeze index API in migration guide #79801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

danhermann
Copy link
Contributor

Relates to #70192 and #78918

@danhermann danhermann added >docs General docs changes :Data Management/Indices APIs APIs to create and manage indices and templates v8.0.0 labels Oct 26, 2021
@danhermann danhermann requested a review from jrodewig October 26, 2021 11:58
@elasticmachine elasticmachine added Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team labels Oct 26, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@danhermann danhermann changed the title Document removal of freeze index API Document removal of freeze index API in migration guide Oct 26, 2021
https://www.elastic.co/blog/significantly-decrease-your-elasticsearch-heap-memory-usage[Improvements
in heap memory usage] have eliminated the reason to freeze indices.
Existing frozen indices can still be unfrozen with the
<<unfreeze-index-api,unfreeze index API>>.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, it doesn't like the reference to <<unfreeze-index-api?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This content is reused in the Stack Install and Upgrade Guide. Internal links, such as <<blah>>, won't work there. You'll need to use {ref}/unfreeze-index-api.html[unfreeze index API] instead.

I'd also reword this sentence slightly:

You can still unfreeze existing frozen indices using the
{ref}/unfreeze-index-api.html[unfreeze index API].

As CJ pointed out in #70192, it'd be good to recommend the frozen data tier as a replacement (if applicable) and provide some steps for migrating formerly frozen indices to the frozen tier.

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danhermann! I left some small comments and suggestions.

Comment on lines 21 to 35
.The deprecated freeze index API has been removed.
[%collapsible]
====
*Details* +
The freeze index API (`POST /<index>/_freeze`) was deprecated in 7.14 and
removed in 8.0.
https://www.elastic.co/blog/significantly-decrease-your-elasticsearch-heap-memory-usage[Improvements
in heap memory usage] have eliminated the reason to freeze indices.
Existing frozen indices can still be unfrozen with the
<<unfreeze-index-api,unfreeze index API>>.

*Impact* +
Requests made to the old freeze index API will return an error.
====

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just add the breaking change to one file. I plan to reorganize this by component in #79162 so it doesn't really matter which file you put it in. If I had to chose, I'd go with indices.asciidoc.

Comment on lines 13 to 14
The freeze index API (`POST /<index>/_freeze`) was deprecated in 7.14 and
removed in 8.0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The freeze index API (`POST /<index>/_freeze`) was deprecated in 7.14 and
removed in 8.0.
The freeze index API (`POST /<index>/_freeze`) has been removed.

https://www.elastic.co/blog/significantly-decrease-your-elasticsearch-heap-memory-usage[Improvements
in heap memory usage] have eliminated the reason to freeze indices.
Existing frozen indices can still be unfrozen with the
<<unfreeze-index-api,unfreeze index API>>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This content is reused in the Stack Install and Upgrade Guide. Internal links, such as <<blah>>, won't work there. You'll need to use {ref}/unfreeze-index-api.html[unfreeze index API] instead.

I'd also reword this sentence slightly:

You can still unfreeze existing frozen indices using the
{ref}/unfreeze-index-api.html[unfreeze index API].

As CJ pointed out in #70192, it'd be good to recommend the frozen data tier as a replacement (if applicable) and provide some steps for migrating formerly frozen indices to the frozen tier.

@danhermann
Copy link
Contributor Author

Thanks, @jrodewig. I made those changes. I thought it would be good to link to the data tiers documentation from the recommendation to consider the frozen tier in place of frozen indices, but I wasn't able to find an asciidoc file that corresponds to those docs.

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @danhermann.

I thought it would be good to link to the data tiers documentation from the recommendation to consider the frozen tier in place of frozen indices, but I wasn't able to find an asciidoc file that corresponds to those docs.

I can work with the docs team to get some better migration docs around this pending the discussion in #70192.

@danhermann
Copy link
Contributor Author

Thanks, @jrodewig!

@danhermann danhermann merged commit 9e93765 into elastic:master Oct 27, 2021
@danhermann danhermann deleted the 70192_migration_guide branch October 27, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >docs General docs changes Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v8.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants