Don't pass feature flag to non-snapshot artifacts #80033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When configuring BWC tests to use feature flags, we need to ensure we don't inadvertently enable the flag on the old version nodes, as those are NOT release builds and therefore fail if the feature flag is present. This commit tweaks our config here to ensure we explicitly enable the flag only on the upgraded nodes.
mark-vieira
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
breskeby
approved these changes
Nov 1, 2021
|
@elasticmachine update branch |
|
@elasticmachine run elasticsearch-ci/release-tests |
1 similar comment
|
@elasticmachine run elasticsearch-ci/release-tests |
|
@elasticmachine update branch |
|
@elasticmachine run elasticsearch-ci/release-tests |
1 similar comment
|
@elasticmachine run elasticsearch-ci/release-tests |
|
@elasticmachine update branch |
|
@elasticmachine run elasticsearch-ci/release-tests |
|
@elasticmachine update branch |
|
@elasticmachine run elasticsearch-ci/release-tests |
|
@mark-vieira does this fix #80479? |
Yep, this addresses that issue as well. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configuring BWC tests to use feature flags, we need to ensure we
don't inadvertently enable the flag on the old version nodes, as those
are NOT release builds and therefore fail if the feature flag is
present. This commit tweaks our config here to ensure we explicitly
enable the flag only on the upgraded nodes.
Closes #78219