Skip to content

[ML] fixing MlMetadata backwards compatibility bug with 7.13-16 #80041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

benwtrent
Copy link
Member

Since 7.13, MlMetadata with reset mode has been serializable. But, this was never adjusted in the 8.0.0 branch.

This commit fixes a serialization bug currently present in alpha + beta1 releases of Elasticsearch 8.0.0.

When MlMetadata exists in a cluster, a rolling upgrade, or mixed-version environment may fail to serialize cluster state between 8.0.0 nodes and nodes 7.13-7.16

@benwtrent benwtrent added >bug :ml Machine learning v8.0.0 labels Oct 28, 2021
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Oct 28, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@benwtrent benwtrent changed the title [ML] fixing MlMetadata backwards compatibility with 7.x [ML] fixing MlMetadata backwards compatibility bug with 7.13-16 Oct 28, 2021
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent benwtrent added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Oct 28, 2021
@elasticsearchmachine elasticsearchmachine merged commit 0eb7d3e into elastic:8.0 Oct 28, 2021
@benwtrent benwtrent deleted the bugfix/ml-fix-mlmetadata-bwc branch October 28, 2021 20:01
droberts195 added a commit to droberts195/elasticsearch that referenced this pull request Nov 5, 2021
The release note about not doing a rolling upgrade to 8.0.0-beta1
if using ML is no longer required because 8.0.0-beta1 was rebuilt
to include elastic#80041.
droberts195 added a commit that referenced this pull request Nov 5, 2021
The release note about not doing a rolling upgrade to 8.0.0-beta1
if using ML is no longer required because 8.0.0-beta1 was rebuilt
to include #80041.
droberts195 added a commit to droberts195/elasticsearch that referenced this pull request Nov 5, 2021
The release note about not doing a rolling upgrade to 8.0.0-beta1
if using ML is no longer required because 8.0.0-beta1 was rebuilt
to include elastic#80041.

Backport of elastic#80417
elasticsearchmachine pushed a commit that referenced this pull request Nov 5, 2021
The release note about not doing a rolling upgrade to 8.0.0-beta1
if using ML is no longer required because 8.0.0-beta1 was rebuilt
to include #80041.

Backport of #80417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >bug :ml Machine learning Team:ML Meta label for the ML team v8.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants