Skip to content

[ML] Fix mocking failure in MlDailyMaintenanceServiceTests #80657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

davidkyle
Copy link
Member

First fixed in #80000 now a different failure with verifyNoMoreInteractions occurs very rarely. This verification is not important, the preceding ones check the behaviour. The Mockito docs offer this advice on verifyNoMoreInteractions which I've taken to heart:

Use it only when it's relevant. Abusing it leads to overspecified, less maintainable tests

Closes #79971

@davidkyle davidkyle added >test Issues or PRs that are addressing/adding tests :ml Machine learning v8.0.0 v7.16.0 v8.1.0 labels Nov 11, 2021
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Nov 11, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.0
7.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Machine learning Team:ML Meta label for the ML team >test Issues or PRs that are addressing/adding tests v7.16.0 v8.0.0-rc1 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] MlDailyMaintenanceServiceTests testBothTasksAreTriggered_DeleteJobsTaskFails failing
5 participants