-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[ML] ML legacy index templates that are no longer needed should be deleted #80876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
droberts195
merged 1 commit into
elastic:master
from
droberts195:delete_ml_legacy_templates
Nov 19, 2021
Merged
[ML] ML legacy index templates that are no longer needed should be deleted #80876
droberts195
merged 1 commit into
elastic:master
from
droberts195:delete_ml_legacy_templates
Nov 19, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leted We no longer need any ML legacy index templates, as we've switched to either composable index templates or system indices. All the ML legacy templates we've created over the years should be deleted, as they're just confusing clutter within the cluster now.
Pinging @elastic/ml-core (Team:ML) |
dimitris-athanasiou
approved these changes
Nov 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
benwtrent
approved these changes
Nov 19, 2021
💔 Backport failed
You can use sqren/backport to manually backport by running |
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Nov 19, 2021
… be deleted We no longer need any ML legacy index templates, as we've switched to either composable index templates or system indices. All the ML legacy templates we've created over the years should be deleted, as they're just confusing clutter within the cluster now. Backport of elastic#80876
droberts195
added a commit
that referenced
this pull request
Nov 20, 2021
There was a mistake in #80876, where the assumption was made that for 8.x versions the old cluster would understand composable templates. This is true for rolling upgrade tests but not full cluster restart tests. This commit fixes that.
droberts195
added a commit
that referenced
this pull request
Nov 20, 2021
There was a mistake in #80876, where the assumption was made that for 8.x versions the old cluster would understand composable templates. This is true for rolling upgrade tests but not full cluster restart tests. This commit fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need any ML legacy index templates, as we've switched to
either composable index templates or system indices. All the ML legacy
templates we've created over the years should be deleted, as they're
just confusing clutter within the cluster now.