Skip to content

[ML] ML legacy index templates that are no longer needed should be deleted #80876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

droberts195
Copy link
Contributor

We no longer need any ML legacy index templates, as we've switched to
either composable index templates or system indices. All the ML legacy
templates we've created over the years should be deleted, as they're
just confusing clutter within the cluster now.

…leted

We no longer need any ML legacy index templates, as we've switched to
either composable index templates or system indices. All the ML legacy
templates we've created over the years should be deleted, as they're
just confusing clutter within the cluster now.
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Nov 19, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droberts195 droberts195 merged commit 0ded096 into elastic:master Nov 19, 2021
@droberts195 droberts195 deleted the delete_ml_legacy_templates branch November 19, 2021 16:32
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.0 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 80876

droberts195 added a commit to droberts195/elasticsearch that referenced this pull request Nov 19, 2021
… be deleted

We no longer need any ML legacy index templates, as we've switched to
either composable index templates or system indices. All the ML legacy
templates we've created over the years should be deleted, as they're
just confusing clutter within the cluster now.

Backport of elastic#80876
elasticsearchmachine pushed a commit that referenced this pull request Nov 19, 2021
… be deleted (#80882)

We no longer need any ML legacy index templates, as we've switched to
either composable index templates or system indices. All the ML legacy
templates we've created over the years should be deleted, as they're
just confusing clutter within the cluster now.

Backport of #80876
droberts195 added a commit that referenced this pull request Nov 20, 2021
There was a mistake in #80876, where the assumption was made
that for 8.x versions the old cluster would understand composable
templates. This is true for rolling upgrade tests but not full
cluster restart tests. This commit fixes that.
droberts195 added a commit that referenced this pull request Nov 20, 2021
There was a mistake in #80876, where the assumption was made
that for 8.x versions the old cluster would understand composable
templates. This is true for rolling upgrade tests but not full
cluster restart tests. This commit fixes that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :ml Machine learning Team:ML Meta label for the ML team v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants