Skip to content

[ML] Fix annotations index maintenance after reindexing #82304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

droberts195
Copy link
Contributor

The code that manages the ML annotations index was not taking
into account the possibility that the usual index name would
be an alias pointing to a reindexed copy of the index. This is
exactly what happens when the upgrade assistant reindexes
indices into the latest Lucene format.

Fixes #82250

The code that manages the ML annotations index was not taking
into account the possibility that the usual index name would
be an alias pointing to a reindexed copy of the index. This is
exactly what happens when the upgrade assistant reindexes
indices into the latest Lucene format.

Fixes elastic#82250
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Jan 6, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

IndexLifecycle.class
IndexLifecycle.class,
// Needed for scaled_float
MapperExtrasPlugin.class
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bit just avoids masses of log spam while the tests run - like #82055

@benwtrent benwtrent added the >bug label Jan 6, 2022
@droberts195 droberts195 merged commit b4fef4b into elastic:master Jan 6, 2022
@droberts195 droberts195 deleted the fix_annotation_index_maintenance_after_reindexing branch January 6, 2022 12:49
droberts195 added a commit to droberts195/elasticsearch that referenced this pull request Jan 6, 2022
The code that manages the ML annotations index was not taking
into account the possibility that the usual index name would
be an alias pointing to a reindexed copy of the index. This is
exactly what happens when the upgrade assistant reindexes
indices into the latest Lucene format.

Fixes elastic#82250
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.0
7.17 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 82304

elasticsearchmachine pushed a commit that referenced this pull request Jan 6, 2022
)

The code that manages the ML annotations index was not taking
into account the possibility that the usual index name would
be an alias pointing to a reindexed copy of the index. This is
exactly what happens when the upgrade assistant reindexes
indices into the latest Lucene format.

Fixes #82250
droberts195 added a commit to droberts195/elasticsearch that referenced this pull request Jan 6, 2022
The code that manages the ML annotations index was not taking
into account the possibility that the usual index name would
be an alias pointing to a reindexed copy of the index. This is
exactly what happens when the upgrade assistant reindexes
indices into the latest Lucene format.

Backport of elastic#82304
droberts195 added a commit to droberts195/elasticsearch that referenced this pull request Jan 6, 2022
Fixes a typo in the name of a new method added in elastic#82304
@droberts195 droberts195 mentioned this pull request Jan 6, 2022
droberts195 added a commit that referenced this pull request Jan 6, 2022
The code that manages the ML annotations index was not taking
into account the possibility that the usual index name would
be an alias pointing to a reindexed copy of the index. This is
exactly what happens when the upgrade assistant reindexes
indices into the latest Lucene format.

Backport of #82304
droberts195 added a commit that referenced this pull request Jan 6, 2022
Fixes a typo in the name of a new method added in #82304
droberts195 added a commit to droberts195/elasticsearch that referenced this pull request Jan 6, 2022
Fixes a typo in the name of a new method added in elastic#82304
droberts195 added a commit to droberts195/elasticsearch that referenced this pull request Jan 6, 2022
Fixes a typo in the name of a new method added in elastic#82304
elasticsearchmachine pushed a commit that referenced this pull request Jan 6, 2022
Fixes a typo in the name of a new method added in #82304
elasticsearchmachine pushed a commit that referenced this pull request Jan 6, 2022
Fixes a typo in the name of a new method added in #82304
astefan pushed a commit to astefan/elasticsearch that referenced this pull request Jan 7, 2022
The code that manages the ML annotations index was not taking
into account the possibility that the usual index name would
be an alias pointing to a reindexed copy of the index. This is
exactly what happens when the upgrade assistant reindexes
indices into the latest Lucene format.

Fixes elastic#82250
astefan pushed a commit to astefan/elasticsearch that referenced this pull request Jan 7, 2022
Fixes a typo in the name of a new method added in elastic#82304
astefan pushed a commit to astefan/elasticsearch that referenced this pull request Jan 7, 2022
The code that manages the ML annotations index was not taking
into account the possibility that the usual index name would
be an alias pointing to a reindexed copy of the index. This is
exactly what happens when the upgrade assistant reindexes
indices into the latest Lucene format.

Fixes elastic#82250
astefan pushed a commit to astefan/elasticsearch that referenced this pull request Jan 7, 2022
Fixes a typo in the name of a new method added in elastic#82304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :ml Machine learning Team:ML Meta label for the ML team v7.17.0 v8.0.0-rc2 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Error creating annotations index after upgrading 6.x -> 7.x -> 8.x
5 participants