-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[ML] Fix annotations index maintenance after reindexing #82304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
droberts195
merged 1 commit into
elastic:master
from
droberts195:fix_annotation_index_maintenance_after_reindexing
Jan 6, 2022
Merged
[ML] Fix annotations index maintenance after reindexing #82304
droberts195
merged 1 commit into
elastic:master
from
droberts195:fix_annotation_index_maintenance_after_reindexing
Jan 6, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code that manages the ML annotations index was not taking into account the possibility that the usual index name would be an alias pointing to a reindexed copy of the index. This is exactly what happens when the upgrade assistant reindexes indices into the latest Lucene format. Fixes elastic#82250
Pinging @elastic/ml-core (Team:ML) |
droberts195
commented
Jan 6, 2022
IndexLifecycle.class | ||
IndexLifecycle.class, | ||
// Needed for scaled_float | ||
MapperExtrasPlugin.class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bit just avoids masses of log spam while the tests run - like #82055
benwtrent
approved these changes
Jan 6, 2022
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Jan 6, 2022
The code that manages the ML annotations index was not taking into account the possibility that the usual index name would be an alias pointing to a reindexed copy of the index. This is exactly what happens when the upgrade assistant reindexes indices into the latest Lucene format. Fixes elastic#82250
💔 Backport failed
You can use sqren/backport to manually backport by running |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 6, 2022
) The code that manages the ML annotations index was not taking into account the possibility that the usual index name would be an alias pointing to a reindexed copy of the index. This is exactly what happens when the upgrade assistant reindexes indices into the latest Lucene format. Fixes #82250
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Jan 6, 2022
The code that manages the ML annotations index was not taking into account the possibility that the usual index name would be an alias pointing to a reindexed copy of the index. This is exactly what happens when the upgrade assistant reindexes indices into the latest Lucene format. Backport of elastic#82304
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Jan 6, 2022
Fixes a typo in the name of a new method added in elastic#82304
Merged
droberts195
added a commit
that referenced
this pull request
Jan 6, 2022
The code that manages the ML annotations index was not taking into account the possibility that the usual index name would be an alias pointing to a reindexed copy of the index. This is exactly what happens when the upgrade assistant reindexes indices into the latest Lucene format. Backport of #82304
droberts195
added a commit
that referenced
this pull request
Jan 6, 2022
Fixes a typo in the name of a new method added in #82304
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Jan 6, 2022
Fixes a typo in the name of a new method added in elastic#82304
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Jan 6, 2022
Fixes a typo in the name of a new method added in elastic#82304
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 6, 2022
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 6, 2022
astefan
pushed a commit
to astefan/elasticsearch
that referenced
this pull request
Jan 7, 2022
The code that manages the ML annotations index was not taking into account the possibility that the usual index name would be an alias pointing to a reindexed copy of the index. This is exactly what happens when the upgrade assistant reindexes indices into the latest Lucene format. Fixes elastic#82250
astefan
pushed a commit
to astefan/elasticsearch
that referenced
this pull request
Jan 7, 2022
Fixes a typo in the name of a new method added in elastic#82304
astefan
pushed a commit
to astefan/elasticsearch
that referenced
this pull request
Jan 7, 2022
The code that manages the ML annotations index was not taking into account the possibility that the usual index name would be an alias pointing to a reindexed copy of the index. This is exactly what happens when the upgrade assistant reindexes indices into the latest Lucene format. Fixes elastic#82250
astefan
pushed a commit
to astefan/elasticsearch
that referenced
this pull request
Jan 7, 2022
Fixes a typo in the name of a new method added in elastic#82304
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code that manages the ML annotations index was not taking
into account the possibility that the usual index name would
be an alias pointing to a reindexed copy of the index. This is
exactly what happens when the upgrade assistant reindexes
indices into the latest Lucene format.
Fixes #82250