Backfill changelogs for 8.1.0 #83341

pugnascotia · 2022-01-31T21:15:47Z

We want to use the new release notes generation process for 8.1.0. In order to do that, we need to backfill the docs/changelog directory with YAML files, to account for the time period up until we started generating YAML
files for all applicable PRs.

Also:

Deprecation information ought to be split into "details" and "impact", so use the same Breaking class for both. Note that this will require a HOMER change as well.
Prune changelogs for previous releases
Remove dry-run mode from the prune task, it's superfluous
Lots and lots of tweaks and fixes

I intend to do another pass before 8.1.0 is released, in order to check that we haven't missed any PRs that ought to have YAML files, and to ensure we don't have any lurking files that ought to have been removed.

elasticmachine · 2022-01-31T21:15:51Z

Pinging @elastic/es-delivery (Team:Delivery)

pugnascotia · 2022-01-31T21:17:14Z

@ywelsch you have some PRs labelled release highlight for 8.1.0, and my PR here has generated changelog YAML files for them. I don't know what to put in the extended release highlight information for these - can you please provide me with the text, or update the YAML files on this branch?

mark-vieira

One minor comment, otherwise LGTM.

...d-tools-internal/src/main/java/org/elasticsearch/gradle/internal/release/ChangelogEntry.java

docs/changelog/82409.yaml

jrodewig · 2022-02-03T18:33:07Z

@elasticmachine run elasticsearch-ci/docs

Removing this while we get the 8.2 migration guide in place in elastic/elasticsearch#83341

jrodewig · 2022-02-03T20:37:10Z

@elasticmachine run elasticsearch-ci/docs

jrodewig · 2022-02-03T22:53:52Z

It looks like master went from 8.1 to 8.2 while this PR was open. When you regenerated the release notes, it looks like it switched everything from 8.1 to 8.2.

I pushed elastic/stack-docs@83a16f2 to swap it back. I don't know if there's a good way to prevent this in the future, but it may be something we want to document.

jrodewig

LGTM overall. I left a couple of minor nits, and an edit for @ywelsch.

Thanks for putting this together!

jrodewig · 2022-02-03T23:45:19Z

docs/reference/release-notes/8.1.asciidoc

+* Copy `trace.id` in threadcontext stash {es-pull}83218[#83218]
+
+Infra/Scripting::
+* Fix duplicated allow lists upon script engine creation {es-pull}82820[#82820] (issue: {es-issue}82778[#82778])


Should this one be here? It looks to be 8.0.0-rc2.

I went trawling through git for this, and I can only find the commit on the 8.1 and master branches, but it doesn't exist on 8.0, so I have to assume the change didn't actually make it into the branch that the labels claim. This is why we need the new process 👍

jrodewig · 2022-02-04T00:03:12Z

docs/changelog/80024.yaml

+  - 80021
+area: Search
+type: enhancement
+summary: Support combining `_shards` preference param with <custom-string>


Suggested change

summary: Support combining `_shards` preference param with <custom-string>

summary: Support combining `_shards` preference param with `<custom-string>`

jrodewig · 2022-02-04T00:27:28Z

docs/changelog/82409.yaml

+    Doc-value-only fields allow users to trade slower query performance for
+    an increased indexing rate and storage space efficiency. This is
+    achieved by disabling inverted structures such as the inverted index or
+    points, and using the columnar storage format of doc values to run
+    queries instead, while still providing the same usual great performance
+    for aggregating and sorting data. {es} {version} supports term and
+    range queries on `numeric`, `date`, `keyword`, `ip`, and `boolean`
+    doc-value-only field types.


@ywelsch Let me know what you think of these changes. I tried to address two minor issues:

I wasn't sure if "date" included date_nanos. It does, but it wasn't clear from this text.

I'm not sure we needed the info about the internal data structures and storage formats. Those felt like implementation details to me and are a little redundant with the doc value docs, but let me know what you think.

Suggested change

Doc-value-only fields allow users to trade slower query performance for

an increased indexing rate and storage space efficiency. This is

achieved by disabling inverted structures such as the inverted index or

points, and using the columnar storage format of doc values to run

queries instead, while still providing the same usual great performance

for aggregating and sorting data. {es} {version} supports term and

range queries on `numeric`, `date`, `keyword`, `ip`, and `boolean`

doc-value-only field types.

You can now run `term` and `range` queries on numeric, `date`, `date_nanos`,

`keyword`, `ip`, and `boolean` fields that only store doc values.

In exchange for slower queries, doc-value-only fields offer:

* Increased indexing rates

* Better storage efficiency

* Great performance for aggregating and sorting data

For more information about doc values, refer to the

{ref}/doc-values.html[`doc_values` mapping parameter documentation].

I'd be great if we had a mapping example of a doc-value-only field we could link to from here.

@jrodewig I missed this ping here, sorry. I'm not sure if this made it in. Note that I've since amended the docs here: #84209
It now provides an example and linkable section.

Awesome. Thanks, @ywelsch!

jrodewig · 2022-02-04T00:28:32Z

docs/changelog/82409.yaml

+# this support
+highlight:
+  notable: false
+  title: Doc-values-only search is now supported on numeric, date, keyword, ip, and boolean types


Suggested change

title: Doc-values-only search is now supported on numeric, date, keyword, ip, and boolean types

title: Doc-values-only search on numeric, `date`, `date_nanos`, `keyword`, `ip`, and `boolean` fields

Forward-port of the `build-tools-internal` parts of elastic#83341.

Forward-port of the `build-tools-internal` parts of #83341.

pugnascotia added >non-issue :Delivery/Tooling Developer tooliing and automation v8.1.0 labels Jan 31, 2022

pugnascotia requested a review from mark-vieira January 31, 2022 21:15

elasticmachine added the Team:Delivery Meta label for Delivery team label Jan 31, 2022

mark-vieira approved these changes Jan 31, 2022

View reviewed changes

...d-tools-internal/src/main/java/org/elasticsearch/gradle/internal/release/ChangelogEntry.java Outdated Show resolved Hide resolved

ywelsch reviewed Feb 1, 2022

View reviewed changes

docs/changelog/82409.yaml Show resolved Hide resolved

ywelsch reviewed Feb 2, 2022

View reviewed changes

docs/changelog/82409.yaml Outdated Show resolved Hide resolved

ywelsch reviewed Feb 2, 2022

View reviewed changes

docs/changelog/82409.yaml Outdated Show resolved Hide resolved

pugnascotia added the >docs General docs changes label Feb 2, 2022

pugnascotia requested a review from jrodewig February 2, 2022 15:03

mark-vieira added v8.2.0 and removed v8.1.0 labels Feb 2, 2022

jrodewig mentioned this pull request Feb 3, 2022

[DOCS] Comment out ES migration guide elastic/stack-docs#1972

Merged

jrodewig added a commit to elastic/stack-docs that referenced this pull request Feb 3, 2022

[DOCS] Comment out ES migration guide (#1972)

83a16f2

Removing this while we get the 8.2 migration guide in place in elastic/elasticsearch#83341

jrodewig added the v8.1.1 label Feb 3, 2022

jrodewig approved these changes Feb 4, 2022

View reviewed changes

pugnascotia changed the base branch from master to 8.1 February 4, 2022 11:19

pugnascotia added 2 commits February 4, 2022 11:26

Apply backfill-changelogs on top of upstream/8.1

336c014

Apply review feedback

33e5876

pugnascotia force-pushed the backfill-changelogs branch from 964ca7a to 33e5876 Compare February 4, 2022 11:58

Regenerate

e38e466

pugnascotia merged commit 4cd2a43 into elastic:8.1 Feb 4, 2022

pugnascotia deleted the backfill-changelogs branch February 4, 2022 14:36

pugnascotia added a commit to pugnascotia/elasticsearch that referenced this pull request Feb 4, 2022

Make improvements to the release notes generator

2afe7f1

Forward-port of the `build-tools-internal` parts of elastic#83341.

pugnascotia mentioned this pull request Feb 4, 2022

Make improvements to the release notes generator #83525

Merged

jrodewig mentioned this pull request Feb 4, 2022

[DOCS] Remove major release references from migration guide #83555

Merged

pugnascotia added a commit that referenced this pull request Feb 7, 2022

Make improvements to the release notes generator (#83525)

bafdcbd

Forward-port of the `build-tools-internal` parts of #83341.

jrodewig mentioned this pull request Feb 9, 2022

[DOCS] Add 8.1.0 release notes #83736

Merged

	summary: Support combining `_shards` preference param with <custom-string>
	summary: Support combining `_shards` preference param with `<custom-string>`

	title: Doc-values-only search is now supported on numeric, date, keyword, ip, and boolean types
	title: Doc-values-only search on numeric, `date`, `date_nanos`, `keyword`, `ip`, and `boolean` fields

Backfill changelogs for 8.1.0 #83341

Backfill changelogs for 8.1.0 #83341

Uh oh!

Conversation

pugnascotia commented Jan 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Jan 31, 2022

Uh oh!

pugnascotia commented Jan 31, 2022

Uh oh!

mark-vieira left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jrodewig commented Feb 3, 2022

Uh oh!

jrodewig commented Feb 3, 2022

Uh oh!

jrodewig commented Feb 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jrodewig left a comment

Choose a reason for hiding this comment

Uh oh!

jrodewig Feb 3, 2022

Choose a reason for hiding this comment

Uh oh!

pugnascotia Feb 4, 2022

Choose a reason for hiding this comment

Uh oh!

jrodewig Feb 4, 2022

Choose a reason for hiding this comment

Uh oh!

jrodewig Feb 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ywelsch Feb 23, 2022

Choose a reason for hiding this comment

Uh oh!

jrodewig Feb 23, 2022

Choose a reason for hiding this comment

Uh oh!

jrodewig Feb 4, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pugnascotia commented Jan 31, 2022 •

edited

Loading

jrodewig commented Feb 3, 2022 •

edited

Loading

jrodewig Feb 4, 2022 •

edited

Loading