Fix TransportDesiredNodesActionsIT batch tests #83406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Select the current master to submit the blocking cluster state update task. Closes elastic#83386
fcofdez
added
>test
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
reviewed
Feb 2, 2022
| @@ -372,7 +370,7 @@ private UpdateDesiredNodesResponse updateDesiredNodes(DesiredNodes desiredNodes) | |||
| private Runnable blockClusterStateUpdateThread() throws InterruptedException { | |||
| final CountDownLatch unblockClusterStateUpdateTask = new CountDownLatch(1); | |||
| final CountDownLatch blockingClusterStateUpdateTaskExecuting = new CountDownLatch(1); | |||
| final ClusterService clusterService = internalCluster().getMasterNodeInstance(ClusterService.class); | |||
| final ClusterService clusterService = internalCluster().getCurrentMasterNodeInstance(ClusterService.class); | |||
There was a problem hiding this comment.
This API is so trappy. I opened #83407.
| @@ -383,7 +381,8 @@ public ClusterState execute(ClusterState currentState) throws Exception { | |||
|
|
|||
| @Override | |||
| public void onFailure(Exception e) { | |||
|
|
|||
| blockingClusterStateUpdateTaskExecuting.countDown(); | |||
There was a problem hiding this comment.
Recommend also bounding the wait time (assertTrue(blockingClusterStateUpdateTaskExecuting.await(10, TimeUnit.SECONDS)); and similarly for unblockClusterStateUpdateTask).
fcofdez
added
v8.1.0
auto-backport
fcofdez
added a commit
to fcofdez/elasticsearch
that referenced
this pull request
Feb 8, 2022
Select the current master to submit the blocking cluster state update task, otherwise the task never gets executed. Closes elastic#83386
💚 Backport successful
|
fcofdez
added a commit
that referenced
this pull request
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select the current master to submit the blocking cluster state
update task, otherwise the task never gets executed.
Closes #83386