Skip to content

Upgrade jANSI dependency to 2.4.0 #83566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 7, 2022
Merged

Conversation

jkakavas
Copy link
Member

@jkakavas jkakavas commented Feb 7, 2022

2.4.0 Introduces support for linux and macOS aarch64. Without this
we cannot detect whether a terminal is attached to elasticsearch
on macoOS/linux aarch64 and so we do not generate and print the
elastic password and enrollment token on startup

2.4.0 Introduces support for linux and macOS aarch64. Without this
we cannot detect whether a terminal is attached to elasticsearch
on macoOS/linux aarch64 and so we do not generate and print the
elastic password and enrollment token on startup
@jkakavas jkakavas added >bug >upgrade :Security/Security Security issues without another label v8.1.0 labels Feb 7, 2022
@elasticmachine elasticmachine added the Team:Security Meta label for security team label Feb 7, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@elasticsearchmachine
Copy link
Collaborator

Hi @jkakavas, I've created a changelog YAML for you.

@elasticsearchmachine
Copy link
Collaborator

Hi @jkakavas, I've updated the changelog YAML for you.

@jkakavas jkakavas removed the >upgrade label Feb 7, 2022
@elasticsearchmachine
Copy link
Collaborator

Hi @jkakavas, I've updated the changelog YAML for you.

@jkakavas
Copy link
Member Author

jkakavas commented Feb 7, 2022

Hi @jkakavas, I've updated the changelog YAML for you.

Hi @elasticmachine , how helpful of you

@tvernum
Copy link
Contributor

tvernum commented Feb 7, 2022

I looks like you're didn't commit the change to distribution/tools/ansi-console/build.gradle

@jkakavas jkakavas requested a review from tvernum February 7, 2022 05:48
@jkakavas jkakavas added v8.0.1 auto-backport Automatically create backport pull requests when merged labels Feb 7, 2022
Copy link
Contributor

@tvernum tvernum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@costin costin mentioned this pull request Feb 7, 2022
@jkakavas jkakavas merged commit facec15 into elastic:master Feb 7, 2022
jkakavas added a commit to jkakavas/elasticsearch that referenced this pull request Feb 7, 2022
2.4.0 Introduces support for linux and macOS aarch64. Without this
we cannot detect whether a terminal is attached to elasticsearch
on macoOS/linux aarch64 and so we do not generate and print the
elastic password and enrollment token on startup
jkakavas added a commit to jkakavas/elasticsearch that referenced this pull request Feb 7, 2022
2.4.0 Introduces support for linux and macOS aarch64. Without this
we cannot detect whether a terminal is attached to elasticsearch
on macoOS/linux aarch64 and so we do not generate and print the
elastic password and enrollment token on startup
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.1
8.0

weizijun added a commit to weizijun/elasticsearch that referenced this pull request Feb 7, 2022
* upstream/master:
  [DOCS] Switch xrefs to external links (elastic#83590)
  [DOCS] 'features' flag added in elastic#83083 (elastic#83452)
  Rename ChangePolicyforIndexIT to ChangePolicyForIndexIT (elastic#83569)
  Fixing random_sampler tests (elastic#83549)
  Upgrade Checkstyle to 9.3 (elastic#83314)
  Make improvements to the release notes generator (elastic#83525)
  Cleanup DataTierAllocationDecider (elastic#83572)
  Upgrade jANSI dependency to 2.4.0 (elastic#83566)
  Speed up Name Collision Check in Metadata.Builder (elastic#83340)
  SQL: Add range checks to interval multiplication operation (elastic#83478)
  Remove DiscoveryNodes#getAllNodes (elastic#83538)
  Make RoutingNodes behave like a collection (elastic#83540)
  Remove Unused CS Listener from SecurityServerTransportInterceptor (elastic#83556)
jkakavas added a commit that referenced this pull request Feb 8, 2022
2.4.0 Introduces support for linux and macOS aarch64. Without this
we cannot detect whether a terminal is attached to elasticsearch
on macoOS/linux aarch64 and so we do not generate and print the
elastic password and enrollment token on startup
jkakavas added a commit that referenced this pull request Feb 8, 2022
2.4.0 Introduces support for linux and macOS aarch64. Without this
we cannot detect whether a terminal is attached to elasticsearch
on macoOS/linux aarch64 and so we do not generate and print the
elastic password and enrollment token on startup
jkakavas added a commit to jkakavas/elasticsearch that referenced this pull request Feb 8, 2022
We figured out that on Linux and macOS aarch64, we can't
determine whether a terminal is attached to elasticsearch and as
such we don't print the elastic password and enrollmen token on
node first startup. This is resolved in elastic#83566 by updating the
underlying library we use to detect the terminal.
jkakavas added a commit that referenced this pull request Feb 10, 2022
We figured out that on Linux and macOS aarch64, we can't
determine whether a terminal is attached to elasticsearch and as
such we don't print the elastic password and enrollment token on
node first startup. This is resolved in #83566 by updating the
underlying library we use to detect the terminal.

Co-authored-by: Adam Locke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >bug :Security/Security Security issues without another label Team:Security Meta label for security team v8.0.1 v8.1.0 v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants