Runtime fields core-with-mapped tests support tsdb #83577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
external-contributor
weizijun
changed the title
|
@nik9000 can you help to review this PR? |
nik9000
reviewed
Feb 7, 2022
| if (name.equals(DataStreamTimestampFieldMapper.DEFAULT_PATH)) { | ||
| // time_series and data stream indices need timestamp field | ||
| continue; | ||
| } |
| @@ -101,7 +99,6 @@ subprojects { | |||
| 'search/330_fetch_fields/error includes glob pattern', | |||
| // we need a @timestamp field to be defined in index mapping | |||
| 'search/380_sort_segments_on_timestamp/*', | |||
| 'field_caps/40_time_series/*', | |||
There was a problem hiding this comment.
I wonder if this is a bit broad. How many are failing without this?
There was a problem hiding this comment.
The yaml failed because of the setup create index, index mapping has time_series_dimension and time_series_metric.
I remove this line, and run the test, it is ok.
There was a problem hiding this comment.
Could you remove the line from the PR? I think you've covered this in the translater.
Yeah! Thanks for the ping. I've replied inline |
elasticmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
nik9000
approved these changes
Feb 8, 2022
nik9000
added
auto-merge-without-approval
|
@elasticmachine test this please |
|
All merged now. Thanks @weizijun ! |
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Feb 9, 2022
* upstream/master: (166 commits) Bind host all instead of just _site_ when needed (elastic#83145) [DOCS] Fix min/max agg snippets for histograms (elastic#83695) [DOCS] Add deprecation notice for system indices (elastic#83688) Cache ILM policy name on IndexMetadata (elastic#83603) [DOCS] Fix 8.0 breaking changes sort order (elastic#83685) [ML] fix random sampling background query consistency (elastic#83676) Move internal APIs into their own namespace '_internal' Runtime fields core-with-mapped tests support tsdb (elastic#83577) Optimize calculating the presence of a quorum (elastic#83638) Use switch expressions in EnableAllocationDecider and NodeShutdownAllocationDecider (elastic#83641) Note libffi error message in tmpdir docs (elastic#83662) Fix TransportDesiredNodesActionsIT batch tests (elastic#83659) [DOCS] Remove unused upgrade doc files (elastic#83617) [ML] Wait for model process to stop in stop deployment (elastic#83644) [ML] Fix submit after shutdown in process worker service (elastic#83645) Remove req/resp classes associated with HLRC (elastic#83599) Introduce index.version.compatibility setting (elastic#83264) Rename InternalTestCluster#getMasterNodeInstance (elastic#83407) Mute TimeSeriesIndexSearcherTests testCollectInOrderAcrossSegments (elastic#83648) Add rollover add max_primary_shard_docs condition (elastic#80981) ... # Conflicts: # x-pack/plugin/rollup/build.gradle # x-pack/plugin/rollup/src/test/java/org/elasticsearch/xpack/rollup/v2/RollupActionSingleNodeTests.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As runtime fields not support
time_series_dimensionandtime_series_metric, it will lead to the failure of tsdb test case. And tsdb indices require the @timestamp field.So I improve the
runtimeifyMappingPropertiesmethod logic, add some skip rule.time_series_dimensionfield.time_series_metricfield.@timestampfield.And the PR fixed the failed test in #83431