Skip to content

Document that awareness attributes override custom preferences #83818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 11, 2022

Conversation

jtibshirani
Copy link
Contributor

@jtibshirani jtibshirani commented Feb 11, 2022

When selecting replicas in a search, the coordinating node prefers nodes with
the same shard allocation awareness attributes. So even if a search specifies
the same custom preference values, different coordinating nodes may route it
differently because of their awareness attributes.

In 8.0, allocation awareness attributes no longer influence search replica
selection. So although this is a bug, we do not intend to fix it in 7.x or 6.x.
Instead, we document the behavior as a 'warning' and mention a system property
that can be used to disable the behavior.

Addresses #53054.

When selecting replicas in a search, the coordinating node prefers nodes with
the same shard allocation awareness attributes. If the search contains a custom
preference string, then it will be ignored in favor of selecting a node with the
same attributes.

In 8.0, allocation awareness attributes no longer influence search replica
selection. So although this is a bug, we do not intend to fix it in 7.x or 6.x.
Instead, we document the behavior as a 'warning' and mention a system property
that can be used to disable the behavior.
@jtibshirani jtibshirani added >docs General docs changes :Search/Search Search-related issues that do not fall into other categories v7.17.0 labels Feb 11, 2022
@elasticmachine elasticmachine added Team:Search Meta label for search team Team:Docs Meta label for docs team labels Feb 11, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left a non-blocking wording suggestion that you can ignore if wanted.

jtibshirani and others added 2 commits February 11, 2022 14:16
Co-authored-by: James Rodewig <[email protected]>
@jtibshirani jtibshirani merged commit 9a52768 into elastic:7.17 Feb 11, 2022
@jtibshirani jtibshirani deleted the awareness-attributes branch February 11, 2022 22:39
jtibshirani added a commit that referenced this pull request Feb 14, 2022
When selecting replicas in a search, the coordinating node prefers nodes with
the same shard allocation awareness attributes. If the search contains a custom
preference string, then it will be ignored in favor of selecting a node with the
same attributes.

In 8.0, allocation awareness attributes no longer influence search replica
selection. So although this is a bug, we do not intend to fix it in 7.x or 6.x.
Instead, we document the behavior as a 'warning' and mention a system property
that can be used to disable the behavior.
jtibshirani added a commit that referenced this pull request Feb 14, 2022
When selecting replicas in a search, the coordinating node prefers nodes with
the same shard allocation awareness attributes. If the search contains a custom
preference string, then it will be ignored in favor of selecting a node with the
same attributes.

In 8.0, allocation awareness attributes no longer influence search replica
selection. So although this is a bug, we do not intend to fix it in 7.x or 6.x.
Instead, we document the behavior as a 'warning' and mention a system property
that can be used to disable the behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search/Search Search-related issues that do not fall into other categories Team:Docs Meta label for docs team Team:Search Meta label for search team v6.8.24 v7.17.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants