[TRANSFORM] Remove HLRC from single node tests #84220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkyle
added
>test
davidkyle
commented
Feb 22, 2022
| @@ -88,7 +87,7 @@ protected void createReviewsIndex( | |||
| min = 10 + (i % 49); | |||
| } | |||
| int sec = 10 + (i % 49); | |||
| String location = (user + 10) + "," + (user + 15); | |||
| String location = (((user + 10) % 180) - 90) + "," + (((user + 15) % 360) - 180); | |||
There was a problem hiding this comment.
Bulk upload was failing for the test TransformPivotRestSpecialCasesIT::testRestrictiveBucketSelector because the lat,lon values were outside of the range.
| @@ -248,8 +248,8 @@ public void testRestrictiveBucketSelector() throws Exception { | |||
| String indexName = "special_pivot_bucket_selector_reviews"; | |||
| createReviewsIndex(indexName, 1000, 327, "date", false, 5, "affiliate_id"); | |||
|
|
|||
| verifyDestIndexHitsCount(indexName, "special_pivot_bucket_selector-10", 10, 14); | |||
| verifyDestIndexHitsCount(indexName, "special_pivot_bucket_selector-10000", 10000, 14); | |||
| verifyDestIndexHitsCount(indexName, "special_pivot_bucket_selector-10", 10, 41); | |||
There was a problem hiding this comment.
The change here is the result of fixing the geo-coordinates that were failing bulk upload
davidkyle
commented
Feb 22, 2022
| assertEquals((4 + 10), coordinates.get(1), 0.000001); | ||
| assertEquals((4 + 15), coordinates.get(0), 0.000001); | ||
| assertEquals(-76.0, coordinates.get(1), 0.000001); | ||
| assertEquals(-161.0, coordinates.get(0), 0.000001); |
There was a problem hiding this comment.
Also due to the lat/lon change
|
Pinging @elastic/ml-core (Team:ML) |
przemekwitek
approved these changes
Feb 23, 2022
| @@ -477,6 +495,13 @@ protected static String getTransformState(String transformId) throws IOException | |||
| return (Map<?, ?>) transforms.get(0); | |||
| } | |||
|
|
|||
| protected static Map<String, Object> getTransformStateAndStats(int from, int size) throws IOException { | |||
There was a problem hiding this comment.
Since it returns a number of transforms, would it make sense to name it getTransformsStateAndStats?
| }, 120, TimeUnit.SECONDS); | ||
|
|
||
| // We want to make sure our latest state is written before we turn the node off, this makes the testing more reliable | ||
| awaitWrittenIndexerState(CONTINUOUS_TRANSFORM_ID, IndexerState.STARTED.value()); | ||
| } | ||
|
|
||
| private String transformConfig() { |
| TestRestHighLevelClient() { | ||
| super(client(), restClient -> {}, X_CONTENT_ENTRIES); | ||
| } | ||
| private String transformConfig() { |
probakowski
pushed a commit
to probakowski/elasticsearch
that referenced
this pull request
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved
TransformProgressITto be aTransformSingleNodeTestCaseas it uses some internal code and was difficult to write as a REST test.The multi-node tests will be changed in another PR.