Skip to content

Remove deprecated xcontent method #84372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Feb 24, 2022

This removes one of the createParser methods that I deprecated in
#79814, migrating callers to one of the new methods that it created.

This removes one of the `createParser` methods that I deprecated in
 elastic#79814, migrating callers to one of the new methods that it created.
@nik9000 nik9000 added >non-issue :Core/Infra/Core Core issues without another label v8.2.0 labels Feb 24, 2022
@nik9000 nik9000 requested review from rjernst and pgomulka February 24, 2022 21:29
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Feb 24, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@nik9000
Copy link
Member Author

nik9000 commented Feb 24, 2022

After this there's just one more deprecated createParser variant. It has ~150 callers though.

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nik9000 nik9000 changed the title Remove deprecated xcontent method (#84314) Remove deprecated xcontent method Feb 28, 2022
@nik9000
Copy link
Member Author

nik9000 commented Feb 28, 2022

@elasticmachine update branch

@nik9000 nik9000 added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Feb 28, 2022
@elasticsearchmachine elasticsearchmachine merged commit 3c66958 into elastic:master Feb 28, 2022
@nik9000 nik9000 deleted the x_content_parser_config_bytes branch February 28, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Core/Infra/Core Core issues without another label >non-issue Team:Core/Infra Meta label for core/infra team v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants