Cleanup some Inefficiencies in JavaDateFormatter #84922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a couple of smaller inefficiencies that I found in profiling and otherwise. * Iteration over the parsers is faster if we just use an array. * Make some of the object construction more efficient since formats aren't always constants, like in e.g. the index name resolver. * Fix non-static initializer block running useless puts into the static mutable map on every instantiation * no need to even have the map, just inline what it does and save some code, indirection and the iteration over the mutable map
original-brownbear
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
danhermann
approved these changes
Mar 14, 2022
|
Thanks both! |
pgomulka
pushed a commit
to pgomulka/elasticsearch
that referenced
this pull request
Sep 5, 2022
Fixes a couple of smaller inefficiencies that I found in profiling and otherwise. * Iteration over the parsers is faster if we just use an array. * Make some of the object construction more efficient since formats aren't always constants, like in e.g. the index name resolver. * Fix non-static initializer block running useless puts into the static mutable map on every instantiation * no need to even have the map, just inline what it does and save some code, indirection and the iteration over the mutable map
pgomulka
added a commit
that referenced
this pull request
Sep 5, 2022
Fixes a couple of smaller inefficiencies that I found in profiling and otherwise. Iteration over the parsers is faster if we just use an array. Make some of the object construction more efficient since formats aren't always constants, like in e.g. the index name resolver. Fix non-static initializer block running useless puts into the static mutable map on every instantiation no need to even have the map, just inline what it does and save some code, indirection and the iteration over the mutable map backports #84922
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of smaller inefficiencies that I found in profiling and otherwise.
in e.g. the index name resolver and the short streams etc. are just needless allocations
iteration over the mutable map