Remove no-jdk deprecations #85765
Merged
Remove no-jdk deprecations #85765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The no-jdk distributions exist in 7.x and before. They were removed with 8.0. This commit removes the remaining deprecation messages for using the no-jdk distribution. Note that when talking with an older node, we drop the bundledJdk attribute. This is ok because it is only possible for this to not be true when talking with a 7.17 node, during an upgrade, and the usingBundledJdk is retained, which is the important thing if debugging a problem. relates elastic#76896 relates elastic#85758
rjernst
added
:Delivery/Packaging
elasticmachine
added
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Pinging @elastic/es-delivery (Team:Delivery) |
mark-vieira
approved these changes
Apr 11, 2022
| @@ -1440,7 +1436,6 @@ The API returns the following response: | |||
| "vm_name": "OpenJDK 64-Bit Server VM", | |||
| "vm_version": "12+33", | |||
| "vm_vendor": "Oracle Corporation", | |||
| "bundled_jdk": true, | |||
There was a problem hiding this comment.
Is removing this item from this API considered a breaking change?
There was a problem hiding this comment.
I had thought the cluster stats API was not considered covered under our backcompat, but it appears it is in a bit of a gray area. I've added it back here, just always returning true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The no-jdk distributions exist in 7.x and before. They were removed with
8.0. This commit removes the remaining deprecation messages for using
the no-jdk distribution. Note that when talking with an older node, we
drop the bundledJdk attribute. This is ok because it is only possible
for this to not be true when talking with a 7.17 node, during an upgrade,
and the usingBundledJdk is retained, which is the important thing if
debugging a problem.
relates #76896
relates #85758