Add readImmutableMap for Java Map #86353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The readImmutableMap method of StreamInput reads an ImmutableOpenMap. As we work towards elastic#86239, we want to continue using immutable maps, but instead use those from the JDK. This commit renames the existing readImmutableMap to readImmutableOpenMap, and reimplements the existing method to return an immutable Map using Map.of and Map.ofEntries. relates elastic#86239
rjernst
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
original-brownbear
approved these changes
May 4, 2022
| @@ -680,13 +680,28 @@ public Map<String, Object> readMap() throws IOException { | |||
| return (Map<String, Object>) readGenericValue(); | |||
| } | |||
|
|
|||
| public <K, V> Map<K, V> readImmutableMap(Writeable.Reader<K> keyReader, Writeable.Reader<V> valueReader) throws IOException { | |||
There was a problem hiding this comment.
Can we add a comment here, making it clear that valueReader must never return null? I see we're using the immutable open map with optional strings for the values, that will throw NPEs with Map.of( and can't be ported directly. Might be nice to make that clear in the docs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readImmutableMap method of StreamInput reads an ImmutableOpenMap. As
we work towards #86239, we want to continue using immutable maps, but
instead use those from the JDK. This commit renames the existing
readImmutableMap to readImmutableOpenMap, and reimplements the existing
method to return an immutable Map using Map.of and Map.ofEntries.
relates #86239