Get hidden indices stats in GET _cat/shards
#86601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passes a permissive `IndicesOptions` to the indices stats request used within `GET _cat/shards` so that it retrieves stats for hidden indices by default. Also passes the same `IndicesOptions` to the cluster state request so that the two requests get consistent sets of indices. Also parallelises the two requests since there's no dependency between them. Closes elastic#84656 Also relates elastic#32238 since the more permissive `IndicesOptions` used here permits closed indices, which means `GET _cat/shards` will not throw an exception in security-enabled clusters containing closed indices behind aliases.
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
|
I'm unclear on the precise BwC consequences of this change. I hope it's ok given that |
|
Pinging @elastic/clients-team (Team:Clients) |
DaveCTurner
added
the
Supportability
sethmlarson
previously approved these changes
May 10, 2022
DaveCTurner
dismissed
sethmlarson’s stale review
Thanks Seth, I'm dismissing this just so it's not marked as ready-to-merge in my list.
dakrone
approved these changes
May 10, 2022
|
Thanks both! |
DaveCTurner
added a commit
that referenced
this pull request
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes a permissive
IndicesOptionsto the indices stats request usedwithin
GET _cat/shardsso that it retrieves stats for hidden indicesby default.
Also passes the same
IndicesOptionsto the cluster state request sothat the two requests get consistent sets of indices.
Also parallelises the two requests since there's no dependency between
them.
Closes #84656
Also relates #32238 since the more permissive
IndicesOptionsused herepermits closed indices, which means
GET _cat/shardswill not throw anexception in security-enabled clusters containing closed indices behind
aliases.