Skip to content

added warning for required privileges #88438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

added warning for required privileges #88438

wants to merge 1 commit into from

Conversation

robb3rt
Copy link

@robb3rt robb3rt commented Jul 11, 2022

Adjusted the document to ensure alignment and correctness after following changes were made: #81400
and adjusted for proposed solution mentioned here: #81451 (comment)

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

Adjusted the document to ensure alignment and correctness after following changes were made: #81400
and adjusted for proposed solution mentioned here: #81451 (comment)
@elasticsearchmachine elasticsearchmachine added v8.4.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jul 11, 2022
@elasticsearchmachine
Copy link
Collaborator

@robb3rt please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@DJRickyB DJRickyB added the >docs General docs changes label Jul 12, 2022
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Jul 12, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Comment on lines +29 to +30
IMPORTANT: This action deletes system indices and [starting from 8.1](https://github.com/elastic/elasticsearch/pull/81400) system index write-access has been removed from the superuser role. So, if you are performing this action from a user with the superuser role, you need to ensure that the user has another role with the `allow_restricted_indices` set to `true` to be able to delete all system indices.

Copy link
Contributor

@lockewritesdocs lockewritesdocs Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
IMPORTANT: This action deletes system indices and [starting from 8.1](https://github.com/elastic/elasticsearch/pull/81400) system index write-access has been removed from the superuser role. So, if you are performing this action from a user with the superuser role, you need to ensure that the user has another role with the `allow_restricted_indices` set to `true` to be able to delete all system indices.
IMPORTANT: This action deletes system indices. In {es} 8.1 and later, the superuser
role doesn't have write access to system indices. If you execute this request as a
user with the superuser role, you must have an additional role with the
`allow_restricted_indices` privilege set to `true` to delete all system indices.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a suggested rewording of your original text. Let me know if this change makes sense 💡

@abdonpijpelink
Copy link
Contributor

@robb3rt Are you interested in continuing to work on this PR, and apply the suggestion in #88438 (comment)? Otherwise, we'd be happy to take it from here.

@quux00 quux00 added v8.11.0 and removed v8.10.0 labels Aug 16, 2023
@mattc58 mattc58 added v8.12.0 and removed v8.11.0 labels Oct 4, 2023
@mark-vieira mark-vieira added auto-backport Automatically create backport pull requests when merged and removed auto-backport-and-merge labels Oct 4, 2024
@leemthompo
Copy link
Contributor

Important

Elastic documentation is migrating to Markdown for version 9.0+. See the migration guide for details.

ℹ️ What's happening?

  • Starting January 29, we will start closing all unmerged documentation PRs targeting main/master
  • We're migrating from AsciiDoc to Markdown for 9.0+
  • 9.0 docs will be frozen from January 29 until February 20 2024
  • NOTE: PRs that include both code and documentation changes will remain open

What do I need to do?

For <=8.x docs:

  1. Rebase your PR to target the relevant 8.x branch instead
  2. The content can remain in AsciiDoc format

For 9.0+ docs:

Option 1:

  • Draft docs in Markdown
  • Once migration freeze ends, find the relevant page in the new docs system and use the edit options to submit your changes

Option 2:

💡 Need help?

  1. For Elasticians: Ask in #docs Slack channel
  2. For external contributors: Open an issue in elastic/docs-content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v8.3.4 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.