Skip to content

[repository-s3] Update the AWS SDK to 1.12.270 #88932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2022

Conversation

arteam
Copy link
Contributor

@arteam arteam commented Jul 29, 2022

@arteam arteam force-pushed the update-aws-sdk branch 4 times, most recently from c301719 to 67aa552 Compare August 2, 2022 09:19
@arteam arteam marked this pull request as ready for review August 2, 2022 10:53
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Aug 2, 2022
@arteam arteam requested a review from tlrx August 2, 2022 10:54
@arteam arteam added :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs and removed needs:triage Requires assignment of a team area label labels Aug 2, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine elasticsearchmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Aug 2, 2022
@arteam arteam added dependencies and removed Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. labels Aug 2, 2022
@elasticsearchmachine elasticsearchmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Aug 2, 2022
@arteam arteam added >tech debt and removed Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. labels Aug 2, 2022
@elasticsearchmachine elasticsearchmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Aug 2, 2022
@elasticsearchmachine
Copy link
Collaborator

Hi @arteam, I've created a changelog YAML for you.

@@ -38,7 +38,7 @@ httpclient = 4.5.13
httpcore = 4.4.13
httpasyncclient = 4.1.5
commonslogging = 1.1.3
commonscodec = 1.14
commonscodec = 1.15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should only upgrades those dependencies for the module only? This is going to impact many projects/modules. @rjernst do you have an opinion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, we update the transitive dependencies when we do library upgrades, but we can also don't do it in this case because jackson and commonscodec updates are really minor.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at release notes for jackson 2.3.13 and commons codec 1.15 and saw nothing outstanding. There are changes around Base64 and MurmurHash3 but IIUC existing behaviors are not changed.

@arteam arteam added :Core/Infra/Core Core issues without another label and removed :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs labels Aug 17, 2022
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Aug 17, 2022
@elasticsearchmachine elasticsearchmachine removed the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Aug 17, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming you saw nothing outstanding in the SDK release notes :)

@arteam arteam merged commit 9b459a2 into elastic:main Sep 5, 2022
@arteam arteam deleted the update-aws-sdk branch September 5, 2022 08:21
@arteam
Copy link
Contributor Author

arteam commented Sep 5, 2022

Thanks Tanguy!

elasticsearchmachine pushed a commit that referenced this pull request Jan 22, 2024
This commit bumps the aws client dependencies from from 1.11.749 to
1.12.270.  This aligns the versions used in 7.17.x with main. 

(partial) backport of
#88932
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label dependencies >non-issue Team:Core/Infra Meta label for core/infra team v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants