-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[repository-s3] Update the AWS SDK to 1.12.270 #88932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c301719
to
67aa552
Compare
Pinging @elastic/es-distributed (Team:Distributed) |
Hi @arteam, I've created a changelog YAML for you. |
@@ -38,7 +38,7 @@ httpclient = 4.5.13 | |||
httpcore = 4.4.13 | |||
httpasyncclient = 4.1.5 | |||
commonslogging = 1.1.3 | |||
commonscodec = 1.14 | |||
commonscodec = 1.15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should only upgrades those dependencies for the module only? This is going to impact many projects/modules. @rjernst do you have an opinion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually, we update the transitive dependencies when we do library upgrades, but we can also don't do it in this case because jackson
and commonscodec
updates are really minor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at release notes for jackson 2.3.13 and commons codec 1.15 and saw nothing outstanding. There are changes around Base64 and MurmurHash3 but IIUC existing behaviors are not changed.
Pinging @elastic/es-core-infra (Team:Core/Infra) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming you saw nothing outstanding in the SDK release notes :)
Thanks Tanguy! |
This commit bumps the aws client dependencies from from 1.11.749 to 1.12.270. This aligns the versions used in 7.17.x with main. (partial) backport of #88932
Resolves GHSA-c28r-hw5m-5gv3