Skip to content

Docs and yaml tests for viewing API key's limited-by #89443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 23, 2022

Conversation

ywangd
Copy link
Member

@ywangd ywangd commented Aug 18, 2022

This PR updates relevant docs and yaml tests to cover the new feature
of viewing API key's limited-by role descriptors introduced in #89273

Relates: #89058

This PR updates relevant docs and yaml tests to cover the new feature
of viewing API key's limited-by role descriptors introduced in elastic#89273

Relates: elastic#89058
@ywangd ywangd added >docs General docs changes >test Issues or PRs that are addressing/adding tests :Security/Security Security issues without another label v8.5.0 labels Aug 18, 2022
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:Security Meta label for security team labels Aug 18, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

Comment on lines +44 to 48
"with_limited_by":{
"type":"boolean",
"default":false,
"description": "flag to show the limited-by role descriptors of API Keys"
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elastic/clients-team This PR adds a new query parameter to both GetApiKey and QueryApiKey APIs.

@ywangd ywangd added the Team:Clients Meta label for clients team label Aug 18, 2022
@elasticsearchmachine elasticsearchmachine removed the Team:Clients Meta label for clients team label Aug 18, 2022
Copy link
Contributor

@n1v0lg n1v0lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywangd
Copy link
Member Author

ywangd commented Aug 22, 2022

@elasticmachine update branch

Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lockewritesdocs lockewritesdocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦖

@ywangd ywangd merged commit e276fd9 into elastic:main Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Security/Security Security issues without another label Team:Docs Meta label for docs team Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants