Skip to content

Downsampling: add more tests for downsample action #90024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 15, 2022
Merged

Downsampling: add more tests for downsample action #90024

merged 2 commits into from
Sep 15, 2022

Conversation

weizijun
Copy link
Contributor

Add some tests for downsample action

@elasticsearchmachine elasticsearchmachine added v8.5.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Sep 13, 2022
@pxsalehi pxsalehi added :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data and removed needs:triage Requires assignment of a team area label labels Sep 13, 2022
@pxsalehi
Copy link
Member

@elasticmachine test this please

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Sep 13, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@csoulios csoulios self-requested a review September 14, 2022 13:58
@csoulios csoulios self-assigned this Sep 14, 2022
@csoulios csoulios added the >test Issues or PRs that are addressing/adding tests label Sep 14, 2022
csoulios
csoulios suggested changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@csoulios csoulios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting those tests.
I have left a small comment.

@csoulios
Copy link
Contributor

@elasticmachine test this please

@csoulios csoulios merged commit f50410e into elastic:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csoulios csoulios csoulios approved these changes

Assignees

@csoulios csoulios

Labels
external-contributor Pull request authored by a developer outside the Elasticsearch team :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weizijun @pxsalehi @elasticsearchmachine @csoulios