Skip to content

InternalSnapshotInfoService refactor #90087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 23, 2022

Conversation

thecoop
Copy link
Member

@thecoop thecoop commented Sep 15, 2022

Refactor some internals of InternalSnapshotInfoService I spotted during #90006

@thecoop thecoop requested a review from ywelsch September 15, 2022 09:54
@thecoop thecoop added :Core/Infra/Core Core issues without another label >refactoring labels Sep 15, 2022
@ywelsch ywelsch requested review from original-brownbear and removed request for ywelsch September 15, 2022 10:21
@csoulios csoulios added v8.6.0 and removed v8.5.0 labels Sep 21, 2022
@thecoop thecoop marked this pull request as ready for review September 22, 2022 14:54
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Sep 22, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Contributor

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @thecoop !

@thecoop
Copy link
Member Author

thecoop commented Sep 23, 2022

@elasticsearchmachine rerun elasticsearch-ci/part-1

@thecoop thecoop closed this Sep 23, 2022
@thecoop thecoop force-pushed the InternalSnapshotInfoService-refactor branch from 9f3e6fb to 7eaa370 Compare September 23, 2022 09:03
@thecoop thecoop reopened this Sep 23, 2022
@thecoop
Copy link
Member Author

thecoop commented Sep 23, 2022

@elasticsearchmachine update main

@thecoop thecoop merged commit ed9fed7 into elastic:main Sep 23, 2022
@thecoop thecoop deleted the InternalSnapshotInfoService-refactor branch September 23, 2022 12:56
Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >refactoring Team:Core/Infra Meta label for core/infra team v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants