Skip to content

Revert "Remove ImmutableOpenMap from snapshot services" #90287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 23, 2022

Conversation

thecoop
Copy link
Member

@thecoop thecoop commented Sep 23, 2022

Reverts #90006

This caused a performance regression with large snapshot counts

@thecoop thecoop marked this pull request as ready for review September 23, 2022 08:56
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Sep 23, 2022
@thecoop thecoop added :Core/Infra/Core Core issues without another label :Performance All issues related to Elasticsearch performance including regressions and investigations >regression and removed needs:triage Requires assignment of a team area label labels Sep 23, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-perf (Team:Performance)

@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team Team:Performance Meta label for performance team labels Sep 23, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine
Copy link
Collaborator

Hi @thecoop, I've created a changelog YAML for you.

@thecoop thecoop removed :Performance All issues related to Elasticsearch performance including regressions and investigations Team:Performance Meta label for performance team labels Sep 23, 2022
@thecoop thecoop force-pushed the revert-90006-immutablemap-snapshots branch from 84c0b8c to ccc86cb Compare September 23, 2022 09:40
@thecoop
Copy link
Member Author

thecoop commented Sep 23, 2022

@elasticsearchmachine rerun elasticsearch-ci/part-2

@thecoop thecoop merged commit e1c284a into main Sep 23, 2022
@thecoop thecoop deleted the revert-90006-immutablemap-snapshots branch September 23, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >regression Team:Core/Infra Meta label for core/infra team v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants