Skip to content

Transport threads and _hot_threads #90482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

grcevski
Copy link
Contributor

Add special handling for reported CPU time
of transport threads in the hot threads
report. Transport threads always run, but
their other time is typically idle instead
of actually runnable.

Closes #90334

Add special handling for reported CPU time
of transport threads in the hot threads
report. Transport threads always run, but
their other time is typically idle instead
of actually runnable.

Closes elastic#90334
@grcevski grcevski added >enhancement :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team v8.6.0 labels Sep 28, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine
Copy link
Collaborator

Hi @grcevski, I've created a changelog YAML for you.

@grcevski
Copy link
Contributor Author

@elasticsearchmachine run elasticsearch-ci/part-2

Copy link
Member

@thecoop thecoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grcevski grcevski merged commit 32f166d into elastic:main Oct 4, 2022
@grcevski
Copy link
Contributor Author

grcevski commented Oct 4, 2022

Thanks Simon!

@grcevski grcevski deleted the hot_threads/transport branch October 4, 2022 19:09
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request May 24, 2023
A completely idle `transport_worker` thread is reported as `0.0%` idle,
which is confusing. Moreover the docs on the network threading model do
not reflect the changes made in elastic#90482. This commit fixes both of those
things.
DaveCTurner added a commit that referenced this pull request May 25, 2023
A completely idle `transport_worker` thread is reported as `0.0%` idle,
which is confusing. Moreover the docs on the network threading model do
not reflect the changes made in #90482. This commit fixes both of those
things.
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request May 25, 2023
Backports the docs changes from elastic#96315, reflecting the change introduced
in elastic#90482, but adjusting them slightly to reflect the different
behaviour in earlier versions.
elasticsearchmachine pushed a commit that referenced this pull request May 25, 2023
Backports the docs changes from #96315, reflecting the change introduced
in #90482, but adjusting them slightly to reflect the different
behaviour in earlier versions.

Co-authored-by: Elastic Machine <[email protected]>
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request May 25, 2023
Backports the docs changes from elastic#96315, reflecting the change introduced
in elastic#90482, but adjusting them slightly to reflect the different
behaviour in earlier versions.

Co-authored-by: Elastic Machine <[email protected]>
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request May 25, 2023
Backports the docs changes from elastic#96315, reflecting the change introduced
in elastic#90482, but adjusting them slightly to reflect the different
behaviour in earlier versions.

Co-authored-by: Elastic Machine <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request May 25, 2023
Backports the docs changes from #96315, reflecting the change introduced
in #90482, but adjusting them slightly to reflect the different
behaviour in earlier versions.

Co-authored-by: Elastic Machine <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request May 25, 2023
Backports the docs changes from #96315, reflecting the change introduced
in #90482, but adjusting them slightly to reflect the different
behaviour in earlier versions.

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >enhancement Team:Core/Infra Meta label for core/infra team v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hot threads should treat other= time on transport workers as idle time
3 participants