-
Notifications
You must be signed in to change notification settings - Fork 25.2k
EQL samples #91312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EQL samples #91312
Conversation
the memory has to be accounted only after circuitBreaker.addEstimateBytesAndMaybeBreak() succeeded otherwise the cleanup is performed with a wrong value
Hi @luigidellaquila, I've created a changelog YAML for you. |
Pinging @elastic/es-ql (Team:QL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I've left one comment.
Also, please update the description of the PR to include the list of PRs that are part of this larger one. Thanks.
docs/changelog/85206.yaml
Outdated
@@ -0,0 +1,5 @@ | |||
pr: 85206 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this file is needed anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 removed
* main: (163 commits) [DOCS] Edits frequent items aggregation (elastic#91564) Handle providers of optional services in ubermodule classloader (elastic#91217) Add `exportDockerImages` lifecycle task for exporting docker tarballs (elastic#91571) Fix CSV dependency report output file location in DRA CI job Fix variable placeholder for Strings.format calls (elastic#91531) Fix output dir creation in ConcatFileTask (elastic#91568) Fix declaration of dependencies in DRA snapshots CI job (elastic#91569) Upgrade Gradle Enterprise plugin to 3.11.4 (elastic#91435) Ingest DateProcessor (small) speedup, optimize collections code in DateFormatter.forPattern (elastic#91521) Fix inter project handling of generateDependenciesReport (elastic#91555) [Synthetics] Add synthetics-* read to fleet-server (elastic#91391) [ML] Copy more settings when creating DF analytics destination index (elastic#91546) Reduce CartesianCentroidIT flakiness (elastic#91553) Propagate last node to reinitialized routing tables (elastic#91549) Forecast write load during rollovers (elastic#91425) [DOCS] Warn about potential overhead of named queries (elastic#91512) Datastream unavailable exception metadata (elastic#91461) Generate docker images and dependency report in DRA ci job (elastic#91545) Support cartesian_bounds aggregation on point and shape (elastic#91298) Add support for EQL samples queries (elastic#91312) ... # Conflicts: # x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/downsample/RollupShardIndexer.java
A Sample query searches for events matching the defined filters, regardless of their temporal order (unlike Sequences, where events have to form a temporal sequence).
Like for sequences, a sample query can define one or more join keys.
As an example, a sample query could look like the following:
The result is a set of samples, where each sample is made of N events, one per filter. Events in a sample have the same value for the join key(s) (defined with the
by
keyword;host
andos
/op_sys
in the example above).With current implementation, the result contains at most one sample for each join key value.
Includes the following PRs: