Skip to content

Fix corrupted Metadata from index and alias having the same name (#91456) #91469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

original-brownbear
Copy link
Contributor

This fixes a bug introduced in #87863 which added a Metadata copy constructor with separate name collision checks that assumed index name and alias names were already validated in IndexMetada. => fixed corrupted states by actually adding the validation to IndexMetadata to make it impossible to instantiate a broken IndexMetadata in the first place.

back port of #91456

…stic#91456)

This fixes a bug introduced in elastic#87863
which added a Metadata copy constructor with separate name collision checks that
assumed index name and alias names were already validated in `IndexMetada`.
=> fixed corrupted states by actually adding the validation to `IndexMetadata`
to make it impossible to instantiate a broken `IndexMetadata` in the first place.
@original-brownbear original-brownbear added :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. backport auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Nov 9, 2022
@elasticsearchmachine elasticsearchmachine merged commit c1310c4 into elastic:8.5 Nov 9, 2022
@original-brownbear original-brownbear deleted the 91456-8.5 branch November 9, 2022 16:13
@original-brownbear original-brownbear restored the 91456-8.5 branch November 30, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. v8.5.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants