Fix RecyclerBytesStreamOutput corrupting when ending write on page boundary #95114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…undary Fixes the fact that we don't put the current page offset to zero when we already have capacity in the buffer but are not on the last page because of a seek.
original-brownbear
added
>bug
:Distributed Coordination/Network
|
Hi @original-brownbear, I've created a changelog YAML for you. |
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
| currentCapacity += pageSize; | ||
| } | ||
| if (currentPageOffset == pageSize) { |
There was a problem hiding this comment.
This is also faster for the rare case where we have to allocate multiple pages in a loop to make space here.
DaveCTurner
approved these changes
Apr 10, 2023
|
Thanks David!
Incoming today, I found another bug with this thing I believe and will add some more testing to that PR. |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
May 24, 2023
…undary (elastic#95114) Fixes the fact that we don't put the current page offset to zero when we already have capacity in the buffer but are not on the last page because of a seek.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
May 31, 2023
DaveCTurner
added a commit
that referenced
this pull request
May 31, 2023
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
May 31, 2023
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 31, 2023
pquentin
pushed a commit
to pquentin/elasticsearch
that referenced
this pull request
May 31, 2023
pquentin
added a commit
that referenced
this pull request
May 31, 2023
* [DOCS] Forward port 8.7.1 release notes * Add known issue docs for #95114 (#96448) --------- Co-authored-by: David Turner <[email protected]>
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Nov 3, 2023
The recycled buffer issued was fixed in elastic#95114, so we can unmute the test See elastic#95096
arteam
added a commit
that referenced
this pull request
Nov 6, 2023
The recycled buffer issued was fixed in #95114, so we can unmute the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the fact that we don't put the current page offset to zero when we already have capacity in the buffer but are not on the last page because of a seek.
Also removes unused
reset()method since it added one needless place for me to check when trying to reason this out.