-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[Ingest][convert-processor] Added MAC type in convert processor #96183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest][convert-processor] Added MAC type in convert processor #96183
Conversation
Documentation preview: |
Pinging @elastic/es-data-management (Team:Data Management) |
Thank you for the pull request, @vinit-chauhan! I did a bit of history spelunking, and the reason there's an Long story short, it was added as a convenience, yes, but more importantly it was added for feature parity with the pre-existing Another consideration is that Elasticsearch has a proper With the history/origin of the On the bright side, that doesn't mean you can't validate whether Strings look like mac addresses in an ingest pipeline! Here's a script processor that's a reasonably faithful translation of your code:
invoking it like this:
gives the following result:
|
This PR here is to add a new
mac
type in the convert processor. It works similarly to an IP processor which would assert the format of the MAC Address.It is seen that Elasticsearch encourages users to store the MAC Address in the RFC 7042 format Here. This PR will add the capability to assert and convert the MAC Address to the suggested format and throws an error if MAC Address is invalid.