Clean up adjustSearchType method
#96334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-search (Team:Search) |
javanna
reviewed
May 24, 2023
| @@ -414,11 +420,6 @@ static void adjustSearchType(SearchRequest searchRequest, boolean singleShard) { | |||
| searchRequest.requestCache(false); | |||
| searchRequest.searchType(QUERY_THEN_FETCH); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
should we also move up the isSuggestOnly branch and return from it?
There was a problem hiding this comment.
Yes! That also makes sense. I will make the change.
javanna
approved these changes
May 25, 2023
|
@javanna Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the knn check for adjusting search type to the top of the method instead of possibly "adjusting" the search type multiple times. Purely mechanical change for readability.