Skip to content

Universal Profiling: Remove cluster id from metrics mapping #96335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2023
Merged

Universal Profiling: Remove cluster id from metrics mapping #96335

merged 1 commit into from
May 25, 2023

Conversation

christos68k
Copy link
Member

With this PR the cluster id is removed from the metrics mapping. It is redundant and doesn't need to be stored in the customer's cluster.

@elasticsearchmachine elasticsearchmachine added v8.9.0 needs:triage Requires assignment of a team area label labels May 24, 2023
@christos68k christos68k added Team:Universal Profiling and removed needs:triage Requires assignment of a team area label labels May 24, 2023
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label and removed Team:Universal Profiling labels May 24, 2023
@christos68k christos68k added the :UniversalProfiling/Application Elastic Universal Profiling REST APIs and infrastructure label May 24, 2023
@elasticsearchmachine elasticsearchmachine added Team:Universal Profiling and removed needs:triage Requires assignment of a team area label labels May 24, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/profiling (Team:Universal Profiling)

danielmitterdorfer
danielmitterdorfer approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

rockdaboot
rockdaboot approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@rockdaboot rockdaboot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christos68k christos68k merged commit 39c83d7 into elastic:main May 25, 2023
@HiDAl HiDAl mentioned this pull request May 25, 2023
Merged
@christos68k christos68k deleted the ck/profiling/metrics branch June 13, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmitterdorfer danielmitterdorfer danielmitterdorfer approved these changes

@rockdaboot rockdaboot rockdaboot approved these changes

Assignees
No one assigned
Labels
>enhancement :UniversalProfiling/Application Elastic Universal Profiling REST APIs and infrastructure v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christos68k @elasticsearchmachine @danielmitterdorfer @rockdaboot