Fix race in testCancelledRecoveryAbortsDownloadPromptly #96431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the source node applies the cluster state before the target then it responds with an `IllegalIndexShardStateException` which makes the target retry. But we don't want any retries. This commit avoids the race by delaying the response on the transport layer. Closes elastic#96427
DaveCTurner
added
>test
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
added
the
auto-merge-without-approval
|
@elasticmachine update branch |
DaveCTurner
deleted the
2023-05-30-fix-testCancelledRecoveryAbortsDownloadPromptly
branch
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jun 5, 2023
This test issue was addressed in elastic#96431 but without unmuting the test.
DaveCTurner
added a commit
that referenced
this pull request
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the source node applies the cluster state before the target then it responds with an
IllegalIndexShardStateExceptionwhich makes the target retry. But we don't want any retries. This commit avoids the race by delaying the response on the transport layer.Closes #96427