Port DLM permissions test to internal REST test style #96434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1v0lg
added
>test
n1v0lg
commented
May 30, 2023
| @@ -0,0 +1,37 @@ | |||
| = Keystore Details | |||
There was a problem hiding this comment.
This and the other files under /ssl are copy and paste from another test, so that we have valid certificate material ssl settings. The ssl settings are not strictly necessary for the REST test, but nice to have. AFAIK, we don't currently have a good way to re-use the certs across multiple tests packages, so copying these from another test.
n1v0lg
commented
May 30, 2023
| @@ -23,8 +24,6 @@ dependencies { | |||
| testImplementation project(':modules:data-streams') | |||
| } | |||
|
|
|||
| addQaCheckDependencies(project) | |||
There was a problem hiding this comment.
Not needed anymore since we can remove qa entirely.
|
@elasticmachine update branch |
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Just realized Keith is in vacation, so re-assigning reviewers. |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
n1v0lg
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting the DLM permissions REST test to the new style of cluster tests. This has the usual nice perks, and also allows us to remove the separate
qa/with-securitypackage.No functional or test logic changes.
I didn't suggest this as part of the PR review for #95512 so as not to block that PR further, and also because I wasn't sure about the overhead of making this change (it did end up taking some battling with gradle).