Skip to content

Format message only when debug is enabled #96437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

idegtiarenko
Copy link
Contributor

This change uses allocation.decision instead of Decision.single so that we are checking debug flag before formatting explanation message.

This change uses `allocation.decision` instead of `Decision.single` so that we
are checking debug flag before formatting explanation message.
@idegtiarenko idegtiarenko added >non-issue :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.9.0 labels May 30, 2023
@idegtiarenko idegtiarenko requested a review from DaveCTurner May 30, 2023 15:20
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idegtiarenko idegtiarenko merged commit 47c70f9 into elastic:main May 31, 2023
@idegtiarenko idegtiarenko deleted the format_message_only_when_debugging branch May 31, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >non-issue Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants