Ignore BlobStoreIndexShardSnapshot#indexVersion #96450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We track the commit generation as `indexVersion` in each `BlobStoreIndexShardSnapshot`, apparently for "compatibility with v1.0". This value has been unused for a long time, so with this commit we stop tracking it and drop it from the metadata blob. This has no bwc implications because the metadata is parsed in a manner that does not require this field to be present.
DaveCTurner
added
>non-issue
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed (Team:Distributed) |
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
Oops, not true, it defaults to |
|
The full-bwc failures are unrelated flakiness, so this is good to review. |
pxsalehi
approved these changes
May 31, 2023
DaveCTurner
deleted the
2023-05-31-ignore-BlobStoreIndexShardSnapshot-indexVersion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We track the commit generation as
indexVersionin eachBlobStoreIndexShardSnapshot, apparently for "compatibility with v1.0". This value has been unused for a long time, so with this commit we stop tracking it and replace it with a constant0in the metadata blob to satisfy the parsing in older versions.