Skip to content

[DOCS]Corrections for index-mgmt page. #98481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

amyjtechwriter
Copy link
Contributor

@amyjtechwriter amyjtechwriter commented Aug 15, 2023

Corrections to the index management page in ES. An inline compass icon added to page, compass symbol changed to compass symbol, and an old image removed.

Closes: #150

@amyjtechwriter amyjtechwriter added >docs General docs changes :Data Management/Data streams Data streams and their lifecycles Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team auto-backport-and-merge v8.10.0 v8.9.1 labels Aug 15, 2023
@github-actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @amyjtechwriter !

I've left one suggestion to change another "symbol" into "icon".

Copy link
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyjtechwriter amyjtechwriter merged commit 7e907f8 into elastic:main Aug 15, 2023
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.9 Commit could not be cherrypicked due to conflicts
8.11 The branch "8.11" is invalid or doesn't exist

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 98481

@jrodewig
Copy link
Contributor

jrodewig commented Aug 15, 2023

@amyjtechwriter — It looks like you'll need to manually backport this PR. Please reach out to @szabosteve or I if you need help with that.

@szabosteve Can you provide a post-merge review? @amyjtechwriter please incorporate any feedback into a follow-up PR. Thanks!

Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes LGTM! Please let me know if I can help with manual backporting.

csoulios pushed a commit to csoulios/elasticsearch that referenced this pull request Aug 18, 2023
* Corrections for index-mgmt page.

* Update docs/reference/indices/index-mgmt.asciidoc

Co-authored-by: Abdon Pijpelink <[email protected]>

---------

Co-authored-by: Abdon Pijpelink <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport pending :Data Management/Data streams Data streams and their lifecycles >docs General docs changes Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v8.9.1 v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants