Skip to content

Disable VCS stamping #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Disable VCS stamping #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
872fe33
disabled buildvcs
oakrizan Feb 29, 2024
5d3180c
added buildvcs goflag to entrypoint'
oakrizan Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .buildkite/pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ env:
DOCKER_REGISTRY: "docker.elastic.co"
STAGING_IMAGE: "${DOCKER_REGISTRY}/observability-ci"
BUILDX: 1
GOFLAGS: "-buildvcs=false"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, IIUC, the issue is in beats if that's the case, aren't these changes needed to be included in the consumer instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For instance, the elastic-agent team did something similar and they are also consumers of this library (golang-crossbuild):

Copy link
Contributor

@dliappis dliappis Mar 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For instance, the elastic-agent team did something similar and they are also consumers of this library (golang-crossbuild):

FYI @v1v the above PR you mentioned is interesting; the problem didn't get fixed by setting export GOFLAGS='-buildvcs=false' because this value gets overwritten and is hardcoded when docker is invoked here: https://github.com/elastic/beats/blob/main/dev-tools/mage/crossbuild.go#L330 (permalink).

The problem got fixed by avoiding having a nested repo (i.e. cloning beats within another cloned repo (elastic-agent): elastic/elastic-agent@cc81e4b#diff-f8bd7a8bc1f2826590a0bd7c0937871d04d15970ee75a830324888f63ce116f5R19 . A similar reproduction is described here.

vcs stamping issues seem to be rampant after go 1.18.0, e.g. see golang/go#49004 and specifically the commit description in golang/go@4569fe6
See also https://github.com/elastic/endgame-gameover/commit/a9d2c6ca12e81eace3802e39bbd933d4cac7cbc3

cc @alexsapran


steps:
- group: "Staging"
Expand Down
1 change: 1 addition & 0 deletions go/base-arm/rootfs/entrypoint.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ func buildEnvironment(platform string) (map[string]string, error) {
"GOARCH": goarch,
"GOARM": goarm,
"PLATFORM_ID": platformID,
"GOFLAGS": "-buildvcs=false",
}

if err := loadCompilerSettings(goos, arch, env); err != nil {
Expand Down