-
Notifications
You must be signed in to change notification settings - Fork 3.5k
expose shutdown request state of pipeline #13811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kaisecheng
merged 5 commits into
elastic:main
from
kaisecheng:expose_pipeline_shutdown_request_state
Feb 28, 2022
Merged
expose shutdown request state of pipeline #13811
kaisecheng
merged 5 commits into
elastic:main
from
kaisecheng:expose_pipeline_shutdown_request_state
Feb 28, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaauie
requested changes
Feb 23, 2022
Co-authored-by: Ry Biesemeyer <[email protected]>
Co-authored-by: Ry Biesemeyer <[email protected]>
yaauie
approved these changes
Feb 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼 LGTM.
Since Output#close
is sent after the worker thread has been joined, this allows plugins to detect an in-progress shutdown nicely.
kaisecheng
added a commit
to kaisecheng/logstash
that referenced
this pull request
Mar 4, 2022
This commit exposes the pipeline shutdown request state to output plugin Co-authored-by: Ry Biesemeyer <[email protected]>
kaisecheng
added a commit
to kaisecheng/logstash
that referenced
this pull request
Mar 4, 2022
This commit exposes the pipeline shutdown request state to output plugin Co-authored-by: Ry Biesemeyer <[email protected]>
kaisecheng
added a commit
to kaisecheng/logstash
that referenced
this pull request
Mar 4, 2022
This commit exposes the pipeline shutdown request state to output plugin Co-authored-by: Ry Biesemeyer <[email protected]>
kaisecheng
added a commit
that referenced
this pull request
Mar 4, 2022
This commit exposes the pipeline shutdown request state to output plugin Co-authored-by: Ry Biesemeyer <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
Expose the pipeline shutdown request state to plugin
This PR goes with logstash-plugins/logstash-output-http#129
Why is it important/What is the impact to the user?
Checklist
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs