Skip to content

expose shutdown request state of pipeline #13811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kaisecheng
Copy link
Contributor

Release notes

[rn:skip]

What does this PR do?

Expose the pipeline shutdown request state to plugin
This PR goes with logstash-plugins/logstash-output-http#129

Why is it important/What is the impact to the user?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Copy link
Member

@yaauie yaauie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 LGTM.

Since Output#close is sent after the worker thread has been joined, this allows plugins to detect an in-progress shutdown nicely.

@kaisecheng kaisecheng merged commit 21de1c1 into elastic:main Feb 28, 2022
kaisecheng added a commit to kaisecheng/logstash that referenced this pull request Mar 4, 2022
This commit exposes the pipeline shutdown request state to output plugin

Co-authored-by: Ry Biesemeyer <[email protected]>
kaisecheng added a commit to kaisecheng/logstash that referenced this pull request Mar 4, 2022
This commit exposes the pipeline shutdown request state to output plugin

Co-authored-by: Ry Biesemeyer <[email protected]>
kaisecheng added a commit to kaisecheng/logstash that referenced this pull request Mar 4, 2022
This commit exposes the pipeline shutdown request state to output plugin

Co-authored-by: Ry Biesemeyer <[email protected]>
kaisecheng added a commit that referenced this pull request Mar 4, 2022
This commit exposes the pipeline shutdown request state to output plugin

Co-authored-by: Ry Biesemeyer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants