spec: improve ls2ls spec #17114
Merged
spec: improve ls2ls spec #17114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes upstream/downstream convention - upstream: the sending logstash (has an LS output) - downstream: the receiving logstash (has an LS input) - helper `run_logstash_instance` yields the `LogstashService` instance and handles the teardown. - pass the pipeline id and node name to the LS instances via command line flags to make logging easier to differentiate - use the generator input's sequence id to ensure that the _actual_ events generated are received by the downstream pipeline
mashhurs
reviewed
Feb 18, 2025
Co-authored-by: Mashhur <[email protected]>
|
💚 Build Succeeded
History
|
|
It is green with issued pipeline, merging: https://buildkite.com/elastic/logstash-linux-jdk-matrix-pipeline/builds/392#_ |
|
@logstashmachine backport 9.0 |
mashhurs
added a commit
to mashhurs/logstash
that referenced
this pull request
Feb 19, 2025
* spec: improve ls2ls spec - fixes upstream/downstream convention - upstream: the sending logstash (has an LS output) - downstream: the receiving logstash (has an LS input) - helper `run_logstash_instance` yields the `LogstashService` instance and handles the teardown. - pass the pipeline id and node name to the LS instances via command line flags to make logging easier to differentiate - use the generator input's sequence id to ensure that the _actual_ events generated are received by the downstream pipeline * start with port-offset 100 Co-authored-by: Mashhur <[email protected]> --------- Co-authored-by: Mashhur <[email protected]> (cherry picked from commit 9abad66)
|
@logstashmachine backport 8.x |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 19, 2025
* spec: improve ls2ls spec - fixes upstream/downstream convention - upstream: the sending logstash (has an LS output) - downstream: the receiving logstash (has an LS input) - helper `run_logstash_instance` yields the `LogstashService` instance and handles the teardown. - pass the pipeline id and node name to the LS instances via command line flags to make logging easier to differentiate - use the generator input's sequence id to ensure that the _actual_ events generated are received by the downstream pipeline * start with port-offset 100 Co-authored-by: Mashhur <[email protected]> --------- Co-authored-by: Mashhur <[email protected]> (cherry picked from commit 9abad66)
3 tasks
|
@logstashmachine backport 8.18 |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 19, 2025
* spec: improve ls2ls spec - fixes upstream/downstream convention - upstream: the sending logstash (has an LS output) - downstream: the receiving logstash (has an LS input) - helper `run_logstash_instance` yields the `LogstashService` instance and handles the teardown. - pass the pipeline id and node name to the LS instances via command line flags to make logging easier to differentiate - use the generator input's sequence id to ensure that the _actual_ events generated are received by the downstream pipeline * start with port-offset 100 Co-authored-by: Mashhur <[email protected]> --------- Co-authored-by: Mashhur <[email protected]> (cherry picked from commit 9abad66)
3 tasks
|
@logstashmachine backport 9.0 |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 19, 2025
* spec: improve ls2ls spec - fixes upstream/downstream convention - upstream: the sending logstash (has an LS output) - downstream: the receiving logstash (has an LS input) - helper `run_logstash_instance` yields the `LogstashService` instance and handles the teardown. - pass the pipeline id and node name to the LS instances via command line flags to make logging easier to differentiate - use the generator input's sequence id to ensure that the _actual_ events generated are received by the downstream pipeline * start with port-offset 100 Co-authored-by: Mashhur <[email protected]> --------- Co-authored-by: Mashhur <[email protected]> (cherry picked from commit 9abad66)
3 tasks
mashhurs
pushed a commit
that referenced
this pull request
Feb 19, 2025
* spec: improve ls2ls spec - fixes upstream/downstream convention - upstream: the sending logstash (has an LS output) - downstream: the receiving logstash (has an LS input) - helper `run_logstash_instance` yields the `LogstashService` instance and handles the teardown. - pass the pipeline id and node name to the LS instances via command line flags to make logging easier to differentiate - use the generator input's sequence id to ensure that the _actual_ events generated are received by the downstream pipeline * start with port-offset 100 Co-authored-by: Mashhur <[email protected]> --------- Co-authored-by: Mashhur <[email protected]> (cherry picked from commit 9abad66) Co-authored-by: Ry Biesemeyer <[email protected]>
mashhurs
pushed a commit
that referenced
this pull request
Feb 19, 2025
* spec: improve ls2ls spec - fixes upstream/downstream convention - upstream: the sending logstash (has an LS output) - downstream: the receiving logstash (has an LS input) - helper `run_logstash_instance` yields the `LogstashService` instance and handles the teardown. - pass the pipeline id and node name to the LS instances via command line flags to make logging easier to differentiate - use the generator input's sequence id to ensure that the _actual_ events generated are received by the downstream pipeline * start with port-offset 100 Co-authored-by: Mashhur <[email protected]> --------- Co-authored-by: Mashhur <[email protected]> (cherry picked from commit 9abad66) Co-authored-by: Ry Biesemeyer <[email protected]>
mashhurs
pushed a commit
that referenced
this pull request
Feb 19, 2025
* spec: improve ls2ls spec - fixes upstream/downstream convention - upstream: the sending logstash (has an LS output) - downstream: the receiving logstash (has an LS input) - helper `run_logstash_instance` yields the `LogstashService` instance and handles the teardown. - pass the pipeline id and node name to the LS instances via command line flags to make logging easier to differentiate - use the generator input's sequence id to ensure that the _actual_ events generated are received by the downstream pipeline * start with port-offset 100 Co-authored-by: Mashhur <[email protected]> --------- Co-authored-by: Mashhur <[email protected]> (cherry picked from commit 9abad66) Co-authored-by: Ry Biesemeyer <[email protected]>
v1v
pushed a commit
to v1v/logstash
that referenced
this pull request
Feb 25, 2025
* spec: improve ls2ls spec - fixes upstream/downstream convention - upstream: the sending logstash (has an LS output) - downstream: the receiving logstash (has an LS input) - helper `run_logstash_instance` yields the `LogstashService` instance and handles the teardown. - pass the pipeline id and node name to the LS instances via command line flags to make logging easier to differentiate - use the generator input's sequence id to ensure that the _actual_ events generated are received by the downstream pipeline * start with port-offset 100 Co-authored-by: Mashhur <[email protected]> --------- Co-authored-by: Mashhur <[email protected]>
v1v
added a commit
to v1v/logstash
that referenced
this pull request
Feb 25, 2025
…gify * upstream/main: (27 commits) Add Windows 2025 to CI (elastic#17133) Update container acceptance tests with stdout/stderr changes (elastic#17138) entrypoint: avoid polluting stdout (elastic#17125) Fix acceptance test assertions for updated plugin remove (elastic#17126) Fix acceptance test assertions for updated plugin `remove` (elastic#17122) plugins: improve `remove` command to support multiple plugins (elastic#17030) spec: improve ls2ls spec (elastic#17114) allow concurrent Batch deserialization (elastic#17050) CPM handle 404 response gracefully with user-friendly log (elastic#17052) qa: use clean expansion of LS tarball per fixture instance (elastic#17082) Allow capturing heap dumps in DRA BK jobs (elastic#17081) Use centralized source of truth for active branches (elastic#17063) Update logstash_releases.json (elastic#17055) fix logstash-keystore to accept spaces in values when added via stdin (elastic#17039) Don't honor VERSION_QUALIFIER if set but empty (elastic#17032) Release note placeholder might be empty, making parsing lines nil tolerant. (elastic#17026) Fix BufferedTokenizer to properly resume after a buffer full condition respecting the encoding of the input string (elastic#16968) Add short living 9.0 next and update main in CI release version definition. (elastic#17008) Core version bump to 9.1.0 (elastic#16991) Add 9.0 branch to the CI branches definition (elastic#16997) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
run_logstash_instanceyields theLogstashServiceinstance and handles the teardown (prevents teardown getting skipped when an exception occurs before it).Why is it important/What is the impact to the user?
No user impact; better tests same basic coverage.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)