updates to docker image template based on feedback #17494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @jsvd? 🙏
|
* change base images to ubi9-minimal * do all env2yaml related copying in 1 COPY * use -trimpath in go build * move other COPY to end of dockerfile * don't run package manager upgrade * FROM and AS with same case * ENV x=y instead of ENV x y * remove indirect config folder
|
💚 Build Succeeded
History
|
5 tasks
kaisecheng
approved these changes
Apr 9, 2025
There was a problem hiding this comment.
LGTM.
I have built the image and it runs as expected. The permission of file and folder are correct. Exhaustive test is green
mergify bot
pushed a commit
that referenced
this pull request
Apr 9, 2025
* change base images to ubi9-minimal * do all env2yaml related copying in 1 COPY * use -trimpath in go build * move other COPY to end of dockerfile * don't run package manager upgrade * FROM and AS with same case * ENV x=y instead of ENV x y * remove indirect config folder (cherry picked from commit 815fa8b)
jsvd
added a commit
that referenced
this pull request
Apr 9, 2025
* change base images to ubi9-minimal * do all env2yaml related copying in 1 COPY * use -trimpath in go build * move other COPY to end of dockerfile * don't run package manager upgrade * FROM and AS with same case * ENV x=y instead of ENV x y * remove indirect config folder (cherry picked from commit 815fa8b) Co-authored-by: João Duarte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exhaustive test suite: https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/1682