Skip to content

[CI] SEGV during Kibana snapshot promotion test #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
droberts195 opened this issue Apr 3, 2020 · 0 comments · Fixed by #1122
Closed

[CI] SEGV during Kibana snapshot promotion test #1121

droberts195 opened this issue Apr 3, 2020 · 0 comments · Fixed by #1122
Assignees
@droberts195
Labels
>bug :ml

Comments

@droberts195
Copy link
Contributor

The autodetect process crashed during https://kibana-ci.elastic.co/job/elasticsearch+snapshots+verify/446/

The error was:

   │      Fatal error: 'si_signo 11, si_code: 1, si_errno: 0, address: 0x7f3eac0d55bd, library: /home/robert/github/kibana/.es/es-test-cluster/modules/x-pack-ml/platform/linux-x86_64/bin/../lib/libMlModel.so, base: 0x7f3eabcf2000, normalized address: 0x3e35bd', version: 8.0.0-SNAPSHOT (build a7f071a14bc835)

Checking which function that address is in reveals:

[dave@linux lib]$ objdump -T libMlModel.so | grep '^00000000003e[23]' | sort
00000000003e2de0 g    DF .text  0000000000000aaa  Base        _ZN2ml5model29CTokenListDataCategorizerBase17usurpedCategoriesEi
00000000003e3890 g    DF .text  000000000000144f  Base        _ZNK2ml5model29CTokenListDataCategorizerBase20updateModelSizeStatsERNS0_16CResourceMonitor15SModelSizeStatsE
[dave@linux lib]$ c++filt _ZN2ml5model29CTokenListDataCategorizerBase17usurpedCategoriesEi
ml::model::CTokenListDataCategorizerBase::usurpedCategories(int)
@droberts195 droberts195 self-assigned this Apr 3, 2020
droberts195 added a commit to droberts195/ml-cpp that referenced this issue Apr 3, 2020
@droberts195
[ML] Fix off-by-one error in usurped categories
7349199 
The mistake was that m_CategoriesByCount has indexes into
m_Categories, not category IDs (which are one more than
the indices so that they start at 1 rather than 0).

Fixes elastic#1121
@droberts195 droberts195 mentioned this issue Apr 3, 2020
Merged
droberts195 added a commit that referenced this issue Apr 3, 2020
@droberts195
[ML] Fix off-by-one error in usurped categories (#1122)
6595826 
The mistake was that m_CategoriesByCount has indexes into
m_Categories, not category IDs (which are one more than
the indices so that they start at 1 rather than 0).

Fixes #1121
droberts195 added a commit to droberts195/elasticsearch that referenced this issue Apr 4, 2020
@droberts195
[TEST] Unmute CategorizationIT.testNumMatchesAndCategoryPreference
c52a08f 
Should work again now that elastic/ml-cpp#1121
is resolved.
@droberts195 droberts195 mentioned this issue Apr 4, 2020
Merged
droberts195 added a commit to elastic/elasticsearch that referenced this issue Apr 6, 2020
@droberts195
[TEST] Unmute CategorizationIT.testNumMatchesAndCategoryPreference (#…
f0332f4 
…54768)

Should work again now that elastic/ml-cpp#1121
is resolved.
droberts195 added a commit to droberts195/elasticsearch that referenced this issue Apr 7, 2020
@droberts195
[TEST] Unmute CategorizationIT.testNumMatchesAndCategoryPreference
a2908f9 
Should work again now that elastic/ml-cpp#1121
is resolved.

Backport of elastic#54768
@droberts195 droberts195 mentioned this issue Apr 7, 2020
Merged
droberts195 added a commit to elastic/elasticsearch that referenced this issue Apr 7, 2020
@droberts195
[TEST] Unmute CategorizationIT.testNumMatchesAndCategoryPreference (#…
df4ae79 
…54868)

Should work again now that elastic/ml-cpp#1121
is resolved.

Backport of #54768
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@droberts195 droberts195

Labels
>bug :ml
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ML] Fix off-by-one error in usurped categories droberts195/ml-cpp
1 participant
@droberts195