Skip to content

[ML] Move classification and regression loss functions into their own file #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2020

Conversation

tveasey
Copy link
Contributor

@tveasey tveasey commented Feb 25, 2020

We're shortly going to be adding more of these, so separate them out from CBoostedTree.[h|cc].

Copy link
Contributor

@valeriy42 valeriy42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tveasey tveasey merged commit 56550ee into elastic:master Feb 27, 2020
@tveasey tveasey deleted the separate-loss-functions branch February 27, 2020 10:26
tveasey added a commit to tveasey/ml-cpp-1 that referenced this pull request Feb 27, 2020
tveasey added a commit that referenced this pull request Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants