[ML] Correct missing category handling #1042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest |
tveasey
added a commit
to tveasey/ml-cpp-1
that referenced
this pull request
Mar 7, 2020
tveasey
added a commit
that referenced
this pull request
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some places in the code that assumed categorical features don't have missing values which hadn't been updated as part of #1034. I've also updated the encoding schemes so that missing categories map to missing [1]. Finally, I've also improved unit testing w.r.t. missing values.
Since this is fallout from #1034, which isn't yet released, I'm marking as a non-issue.
Closes #1040.
[1] This may not be the best approach to take, but represents the least effort fix for the SIGSEGV.